Skip to content

Fix -Wdangling-capture warning in CalcEngine::GetString() #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dongfengweixiao wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix -Wdangling-capture warning in CalcEngine::GetString() #2434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/CalcManager/Header Files/CalcEngine.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ class CCalcEngine
// returns the ptr to string representing the operator. Mostly same as the button, but few special cases for x^y etc.
static std::wstring_view GetString(int ids)
{
return s_engineStrings[std::to_wstring(ids)];
std::wstring key = std::to_wstring(ids);
return s_engineStrings.at(key);
}
static std::wstring_view GetString(std::wstring_view ids)
{
Expand Down