Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Torr Pressure-Converter Option #2121

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Implement Torr Pressure-Converter Option #2121

wants to merge 8 commits into from
+17 −2

Commits on Feb 10, 2024

  1. Refactor KeyboardShortcutManager.cs for improved readability and main… 

    …tainability

The code changes in this commit simplify the logic in the `OnAcceleratorKeyActivated` method of `KeyboardShortcutManager.cs`.

- Replaced nested if-else statements with concise conditional expressions
- Removed redundant checks for `altPressed` and `controlKeyPressed`
- Consolidated return statements based on key combinations
    @JacobPoteet
    JacobPoteet committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    2074db6 View commit details
    Browse the repository at this point in the history

  2. Add Pressure_Torr as a new unit constant in UnitConverterDataConstant… 

    …s.h.

This commit adds the Pressure_Torr constant to the list of unit constants in the UnitConverterDataConstants.h file.
    @JacobPoteet
    JacobPoteet committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    5901d20 View commit details
    Browse the repository at this point in the history

  3. Add Torr unit to pressure units in UnitConverterDataLoader.cpp 

    This commit adds the Torr unit to the list of pressure units in the UnitConverterDataLoader.cpp file. The Torr unit is assigned a value of 7 and its localized name and abbreviation are retrieved using GetLocalizedStringName(). Additionally, the conversion data for Torr is added to the GetConversionData() function.
    @JacobPoteet
    JacobPoteet committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    9681cfc View commit details
    Browse the repository at this point in the history

  4. Add Torr as a unit abbreviation for Pressure 

    The code changes include adding the unit abbreviation "Torr" for pressure measurement in the Resources.resw file. This change allows users to use "Torr" as an abbreviation when working with pressure calculations.
    @JacobPoteet
    JacobPoteet committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    f67990c View commit details
    Browse the repository at this point in the history

  5. Add Torr as a measurement unit for Pressure. 

    - Add new data entry for UnitName_Torr
- Set value to "Torr"
- Set comment to "A measurement unit for Pressure."
    @JacobPoteet
    JacobPoteet committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    593e05c View commit details
    Browse the repository at this point in the history

  6. Add conversion data for "Atmospheres-Torr" in Test.resw 

    This commit adds a new conversion data entry for "Atmospheres-Torr" in the Test.resw file. The value of this conversion is 0.00131578947368.
    @JacobPoteet
    JacobPoteet committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    c251337 View commit details
    Browse the repository at this point in the history

  7. Refactor UnitConverterDataLoader.cpp to correctly add pressure units 

    The commit fixes a bug in the code where the pressure units were not being added correctly. The issue was resolved by moving the `emplace` statement after adding the `pressureUnits` vector.
    @JacobPoteet
    JacobPoteet committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    a01f7a9 View commit details
    Browse the repository at this point in the history

  8. Revert unrelated optimization

    @JacobPoteet
    JacobPoteet committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    afbb724 View commit details
    Browse the repository at this point in the history