Skip to content

Conversation

@sw-joelmut
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR updates the chai package to its latest version 5.1.2. Starting on version 5.x, this package is ESM-only, so we used import-sync to be able to use this version.

Specific Changes

  • Updated chai from 4.5.0 and 5.1.2 in botbuilder and botframework-streaming libraries.
  • Added import-sync as a dependency in botbuilder and botframework-streaming.
  • Added chai to the depcheck ignore list as it threw a false positive on unused dependency.

Testing

The following images show the installed version.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner November 12, 2024 12:33
@coveralls
Copy link

coveralls commented Nov 12, 2024

Pull Request Test Coverage Report for Build 11797338556

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.704%

Totals Coverage Status
Change from base Build 11687414604: 0.0%
Covered Lines: 20515
Relevant Lines: 23064

💛 - Coveralls

@ceciliaavila
Copy link
Collaborator

We need to replace import-sync as it won't work on Node 22.

@ceciliaavila ceciliaavila marked this pull request as draft January 6, 2025 15:55
@sw-joelmut
Copy link
Collaborator Author

Replaced by #4844

@sw-joelmut sw-joelmut closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants