Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: [#4684] Upgrade d3-format using import-sync for esm-only package #4784

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR updates the d3-format package to its latest version 3.1.0. Starting on version 3.x, this package is ESM-only, so we used import-sync to be able to use this version.

Specific Changes

  • Updated d3-format from 2.0.0 to 3.1.0 in adaptive-expressions library.
  • Added import-sync as a dependency in adaptive-expressions.
  • Added d3-format to the depcheck ignore list as it threw a false positive on unused dependency.
  • Updated the formatNumbers and string classes to import the package d3-format using the importSync function.

Testing

The following images show the installed version and the unit tests passing after the changes.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner November 1, 2024 21:53
@coveralls
Copy link

coveralls commented Nov 1, 2024

Pull Request Test Coverage Report for Build 11636879786

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 84.705%

Totals Coverage Status
Change from base Build 11633766399: 0.001%
Covered Lines: 20517
Relevant Lines: 23066

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants