-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove CVE-2024-37890 vulnerability by updating the ws package #4683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9587628438Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9587628438Details
💛 - Coveralls |
tracyboehrer
approved these changes
Jun 19, 2024
This was referenced Jul 18, 2024
This was referenced Jul 28, 2024
This was referenced Sep 7, 2024
This was referenced Oct 30, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4684
#minor
Description
This PR updates the version of the
ws
package from7.1.2
to7.5.10
to fix the CVE-2024-37890 vulnerability.Along the way, to address this
ws
package issue for thebrowser-functional/browser-echo
project, we have updated allwebpack
related packages to the latest supported node 16 version, fixing the following vulnerabilities.Specific Changes
ws
from7.1.2
to7.5.10
.webpack
,webpack-dev-server
andwebpack-cli
to latest version of each that support node 16.Testing
The following images show the
ws
package updated version, the reduction of vulnerable packages, and the browser-functional/browser-echo working.