Skip to content

Commit

Permalink
Merge branch 'main' into releases/4.22
Browse files Browse the repository at this point in the history
  • Loading branch information
Tracy Boehrer committed Apr 15, 2024
2 parents 2628f0b + 2f45467 commit e07847c
Show file tree
Hide file tree
Showing 10 changed files with 108 additions and 159 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"botbuilder": "4.1.6",
"botbuilder-dialogs-adaptive-runtime": "4.1.6",
"botbuilder-dialogs-adaptive-runtime-core": "4.1.6",
"express": "^4.17.3",
"express": "^4.19.2",
"zod": "^3.22.4"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,10 @@ export class DialogStateManager {
// Get memory scope to search over
const scope = this.getMemoryScope(segments[0].toString());
if (scope == undefined) {
throw new Error(`DialogStateManager.getValue: a scope of '${segments[0]}' wasn't found.`);
console.warn(
`DialogStateManager.getValue: a scope of '${segments[0]}' wasn't found for '${pathExpression}'.`
);
return returnDefault();
}

// Search over path
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ describe('Dialog State Manager', function () {
});

it('raise an error if getValue() called with an invalid scope.', function () {
assert.throws(() => this.dc.state.getValue('foo.bar'));
assert.strictEqual(this.dc.state.getValue('foo.bar'), undefined);
});

it('raise an error if setValue() called with missing path.', function () {
Expand Down
3 changes: 2 additions & 1 deletion libraries/botbuilder/etc/botbuilder.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ import { InvokeResponse } from 'botbuilder-core';
import { IReceiveRequest } from 'botframework-streaming';
import { IStreamingTransportServer } from 'botframework-streaming';
import { MeetingEndEventDetails } from 'botbuilder-core';
import { MeetingInfo } from 'botbuilder-core';
import { MeetingNotification } from 'botbuilder-core';
import { MeetingNotificationResponse } from 'botbuilder-core';
import { MeetingParticipantsEventDetails } from 'botbuilder-core';
Expand Down Expand Up @@ -481,7 +482,7 @@ export function teamsGetTenant(activity: Activity): TenantInfo | null;
export class TeamsInfo {
static cancelOperation(context: TurnContext, operationId: string): Promise<CancelOperationResponse>;
static getFailedEntries(context: TurnContext, operationId: string): Promise<BatchFailedEntriesResponse>;
static getMeetingInfo(context: TurnContext, meetingId?: string): Promise<TeamsMeetingInfo>;
static getMeetingInfo(context: TurnContext, meetingId?: string): Promise<MeetingInfo>;
static getMeetingParticipant(context: TurnContext, meetingId?: string, participantId?: string, tenantId?: string): Promise<TeamsMeetingParticipant>;
static getMember(context: TurnContext, userId: string): Promise<TeamsChannelAccount>;
// @deprecated
Expand Down
6 changes: 3 additions & 3 deletions libraries/botbuilder/src/teamsInfo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
ConversationParameters,
ConversationReference,
TeamsMeetingParticipant,
TeamsMeetingInfo,
MeetingInfo,
Channels,
MeetingNotification,
MeetingNotificationResponse,
Expand Down Expand Up @@ -101,9 +101,9 @@ export class TeamsInfo {
*
* @param context The [TurnContext](xref:botbuilder-core.TurnContext) for this turn.
* @param meetingId The BASE64-encoded id of the Teams meeting.
* @returns The [TeamsMeetingInfo](xref:botbuilder-core.TeamsMeetingInfo) fetched
* @returns The [MeetingInfo](xref:botframework-schema.MeetingInfo) fetched
*/
static async getMeetingInfo(context: TurnContext, meetingId?: string): Promise<TeamsMeetingInfo> {
static async getMeetingInfo(context: TurnContext, meetingId?: string): Promise<MeetingInfo> {
if (!context) {
throw new Error('context is required.');
}
Expand Down
4 changes: 2 additions & 2 deletions libraries/botframework-connector/src/teams/models/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { HttpResponse, ServiceClientOptions, RequestOptionsBase } from '@azure/c
import {
ConversationList,
TeamDetails,
TeamsMeetingInfo,
MeetingInfo,
MeetingNotificationResponse,
TeamsMeetingParticipant,
BatchOperationResponse,
Expand Down Expand Up @@ -112,7 +112,7 @@ export interface TeamsFetchMeetingParticipantOptionalParams extends RequestOptio
/**
* Contains response data for the fetchMeetingInfo operation.
*/
export type TeamsMeetingInfoResponse = TeamsMeetingInfo & {
export type TeamsMeetingInfoResponse = MeetingInfo & {
/**
* The underlying HTTP response.
*/
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
"**/@babel/plugin-proposal-class-properties/@babel/core": "^7.23.2",
"follow-redirects": "^1.15.4",
"@types/ramda": "0.26.0",
"@types/jsonwebtoken": "7.2.8",
"@azure/msal-browser": "^2.38.3",
"@azure/msal-node": "^1.18.4",
"axios": "0.28.0",
Expand All @@ -69,7 +70,6 @@
"@microsoft/api-extractor": "^7.38.2",
"@standardlabs/downlevel-dts": "^0.7.5",
"@standardlabs/is-private": "^1.0.1",
"@types/jsonwebtoken": "7.2.8",
"@types/lodash": "^4.14.134",
"@types/mocha": "^5.2.7",
"@types/sinon": "^9.0.11",
Expand Down
2 changes: 1 addition & 1 deletion testing/bot-integration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"devDependencies": {
"@types/express": "^4.17.7",
"@types/restify": "^8.4.2",
"express": "^4.17.3",
"express": "^4.19.2",
"restify": "^8.5.1"
}
}
49 changes: 27 additions & 22 deletions testing/browser-functional/browser-echo-bot/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1753,21 +1753,21 @@ bn.js@^5.0.0, bn.js@^5.2.1:
resolved "https://registry.yarnpkg.com/bn.js/-/bn.js-5.2.1.tgz#0bc527a6a0d18d0aa8d5b0538ce4a77dccfa7b70"
integrity sha512-eXRvHzWyYPBuB4NBy0cmYQjGitUrtqwbvlzP3G6VFnNRbsZQIxQ10PbKKHt8gZ/HW/D/747aDl+QkDqg3KQLMQ==

[email protected].1:
version "1.20.1"
resolved "https://registry.yarnpkg.com/body-parser/-/body-parser-1.20.1.tgz#b1812a8912c195cd371a3ee5e66faa2338a5c668"
integrity sha512-jWi7abTbYwajOytWCQc37VulmWiRae5RyTpaCyDcS5/lMdtwSz5lOpDE67srw/HYe35f1z3fDQw+3txg7gNtWw==
[email protected].2:
version "1.20.2"
resolved "https://registry.yarnpkg.com/body-parser/-/body-parser-1.20.2.tgz#6feb0e21c4724d06de7ff38da36dad4f57a747fd"
integrity sha512-ml9pReCu3M61kGlqoTm2umSXTlRTuGTx0bfYj+uIUKKYycG5NtSbeetV3faSU6R7ajOPw0g/J1PvK4qNy7s5bA==
dependencies:
bytes "3.1.2"
content-type "~1.0.4"
content-type "~1.0.5"
debug "2.6.9"
depd "2.0.0"
destroy "1.2.0"
http-errors "2.0.0"
iconv-lite "0.4.24"
on-finished "2.4.1"
qs "6.11.0"
raw-body "2.5.1"
raw-body "2.5.2"
type-is "~1.6.18"
unpipe "1.0.0"

Expand Down Expand Up @@ -2351,6 +2351,11 @@ content-type@~1.0.4:
resolved "https://registry.yarnpkg.com/content-type/-/content-type-1.0.4.tgz#e138cc75e040c727b1966fe5e5f8c9aee256fe3b"
integrity sha512-hIP3EEPs8tB9AT1L+NUqtwOAps4mk2Zob89MWXMHjHWg9milF/j4osnnQLXBCBFBk/tvIG/tUc9mOUJiPBhPXA==

content-type@~1.0.5:
version "1.0.5"
resolved "https://registry.yarnpkg.com/content-type/-/content-type-1.0.5.tgz#8b773162656d1d1086784c8f23a54ce6d73d7918"
integrity sha512-nTjqfcBFEipKdXCv4YDQWCfmcLZKm81ldF0pAopTvyrFGVbcR6P/VAAd5G7N+0tTr8QqiU0tFadD6FK4NtJwOA==

convert-source-map@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/convert-source-map/-/convert-source-map-2.0.0.tgz#4b560f649fc4e918dd0ab75cf4961e8bc882d82a"
Expand All @@ -2361,10 +2366,10 @@ [email protected]:
resolved "https://registry.yarnpkg.com/cookie-signature/-/cookie-signature-1.0.6.tgz#e303a882b342cc3ee8ca513a79999734dab3ae2c"
integrity sha512-QADzlaHc8icV8I7vbaJXJwod9HWYp8uCqf1xa4OfNu1T7JVxQIrUgOWtHdNDtPiywmFbiS12VjotIXLrKM3orQ==

cookie@0.5.0:
version "0.5.0"
resolved "https://registry.yarnpkg.com/cookie/-/cookie-0.5.0.tgz#d1f5d71adec6558c58f389987c366aa47e994f8b"
integrity sha512-YZ3GUyn/o8gfKJlnlX7g7xq4gyO6OSuhGPKaaGssGB2qgDUS0gPgtTvoyZLTt9Ab6dC4hfc9dV5arkvc/OCmrw==
cookie@0.6.0:
version "0.6.0"
resolved "https://registry.yarnpkg.com/cookie/-/cookie-0.6.0.tgz#2798b04b071b0ecbff0dbb62a505a8efa4e19051"
integrity sha512-U71cyTamuh1CRNCfpGY6to28lxvNwPG4Guz/EVjgf3Jmzv0vlDp1atT9eS5dDjMYHucpHbWns6Lwf3BKz6svdw==

copy-concurrently@^1.0.0:
version "1.0.5"
Expand Down Expand Up @@ -3098,16 +3103,16 @@ expand-tilde@^2.0.0, expand-tilde@^2.0.2:
homedir-polyfill "^1.0.1"

express@^4.17.1:
version "4.18.2"
resolved "https://registry.yarnpkg.com/express/-/express-4.18.2.tgz#3fabe08296e930c796c19e3c516979386ba9fd59"
integrity sha512-5/PsL6iGPdfQ/lKM1UuielYgv3BUoJfz1aUwU9vHZ+J7gyvwdQXFEBIEIaxeGf0GIcreATNyBExtalisDbuMqQ==
version "4.19.2"
resolved "https://registry.yarnpkg.com/express/-/express-4.19.2.tgz#e25437827a3aa7f2a827bc8171bbbb664a356465"
integrity sha512-5T6nhjsT+EOMzuck8JjBHARTHfMht0POzlA60WV2pMD3gyXw2LZnZ+ueGdNxG+0calOJcWKbpFcuzLZ91YWq9Q==
dependencies:
accepts "~1.3.8"
array-flatten "1.1.1"
body-parser "1.20.1"
body-parser "1.20.2"
content-disposition "0.5.4"
content-type "~1.0.4"
cookie "0.5.0"
cookie "0.6.0"
cookie-signature "1.0.6"
debug "2.6.9"
depd "2.0.0"
Expand Down Expand Up @@ -3322,9 +3327,9 @@ flush-write-stream@^1.0.0:
readable-stream "^2.3.6"

follow-redirects@^1.0.0, follow-redirects@^1.15.4:
version "1.15.5"
resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.15.5.tgz#54d4d6d062c0fa7d9d17feb008461550e3ba8020"
integrity sha512-vSFWUON1B+yAw1VN4xMfxgn5fTUiaOzAJCKBwIIgT/+7CuGy9+r+5gITvP62j3RmaD5Ph65UaERdOSRGUzZtgw==
version "1.15.6"
resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.15.6.tgz#7f815c0cda4249c74ff09e95ef97c23b5fd0399b"
integrity sha512-wWN62YITEaOpSK584EZXJafH1AGpO8RVgElfkuXbTOrPX4fIfOyEpW/CsiNd8JdYrAoOvafRTOEnvsO++qCqFA==

for-in@^1.0.2:
version "1.0.2"
Expand Down Expand Up @@ -5463,10 +5468,10 @@ range-parser@^1.2.1, range-parser@~1.2.1:
resolved "https://registry.yarnpkg.com/range-parser/-/range-parser-1.2.1.tgz#3cf37023d199e1c24d1a55b84800c2f3e6468031"
integrity sha512-Hrgsx+orqoygnmhFbKaHE6c296J+HTAQXoxEF6gNupROmmGJRoyzfG3ccAveqCBrwr/2yxQ5BVd/GTl5agOwSg==

[email protected].1:
version "2.5.1"
resolved "https://registry.yarnpkg.com/raw-body/-/raw-body-2.5.1.tgz#fe1b1628b181b700215e5fd42389f98b71392857"
integrity sha512-qqJBtEyVgS0ZmPGdCFPWJ3FreoqvG4MVQln/kCgF7Olq95IbOp0/BWyMwbdtn4VTvkM8Y7khCQ2Xgk/tcrCXig==
[email protected].2:
version "2.5.2"
resolved "https://registry.yarnpkg.com/raw-body/-/raw-body-2.5.2.tgz#99febd83b90e08975087e8f1f9419a149366b68a"
integrity sha512-8zGqypfENjCIqGhgXToC8aB2r7YrBX+AQAfIPs/Mlk+BtPTztOvTS01NRW/3Eh60J+a48lt8qsCzirQ6loCVfA==
dependencies:
bytes "3.1.2"
http-errors "2.0.0"
Expand Down
Loading

0 comments on commit e07847c

Please sign in to comment.