Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to managed identity updates #488

Merged
merged 9 commits into from
Feb 13, 2025
Merged

Conversation

davidxw
Copy link
Member

@davidxw davidxw commented Feb 12, 2025

This pull request includes several updates to improve the deployment and local development experience for the Azure Chat application. The most important changes include adding support for managed identities, simplifying the deployment process using the Azure Developer CLI, and enhancing the local development setup scripts.

Deployment and Local Development Improvements:

  • Managed Identities Support:

    • Added add_localdev_roles.ps1 and add_localdev_roles.sh scripts to grant necessary IAM roles for local development. [1] [2]
    • Updated infra/resources.bicep to conditionally include secrets in Key Vault and app settings based on the disableLocalAuth flag. [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Azure Developer CLI Deployment:

    • Added instructions to docs/4-deploy-to-azure.md for deploying the application using the Azure Developer CLI.
  • Local Development Setup:

    • Updated docs/2-run-locally.md to include a note on using the Azure Developer CLI to populate environment variables.
    • Added appreg_setup.sh script for creating app registrations in Entra ID for local development.

Documentation Updates:

  • README.md:
    • Updated to include both appreg_setup.ps1 and appreg_setup.sh scripts for creating app registrations.

Code Enhancements:

  • Authentication:
    • Updated src/features/auth-page/auth-api.ts to dynamically set the isAdmin property based on a list of admin emails.

@davidxw davidxw requested a review from FreddyAyala February 12, 2025 03:52
Copy link
Collaborator

@olafwrieden olafwrieden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really useful, just made a few callouts as I was reading through :)

docs/2-run-locally.md Outdated Show resolved Hide resolved
docs/4-deploy-to-azure.md Outdated Show resolved Hide resolved
scripts/add_localdev_roles.sh Outdated Show resolved Hide resolved
scripts/appreg_setup.sh Outdated Show resolved Hide resolved
@davidxw davidxw requested a review from olafwrieden February 12, 2025 22:49
@davidxw davidxw merged commit e4f3a15 into main Feb 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants