-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to managed identity updates #488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from main
olafwrieden
requested changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really useful, just made a few callouts as I was reading through :)
olafwrieden
approved these changes
Feb 12, 2025
…ment guidance in documentation
…soft/azurechat into feature_managed_Identities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to improve the deployment and local development experience for the Azure Chat application. The most important changes include adding support for managed identities, simplifying the deployment process using the Azure Developer CLI, and enhancing the local development setup scripts.
Deployment and Local Development Improvements:
Managed Identities Support:
add_localdev_roles.ps1
andadd_localdev_roles.sh
scripts to grant necessary IAM roles for local development. [1] [2]infra/resources.bicep
to conditionally include secrets in Key Vault and app settings based on thedisableLocalAuth
flag. [1] [2] [3] [4] [5] [6] [7] [8] [9]Azure Developer CLI Deployment:
docs/4-deploy-to-azure.md
for deploying the application using the Azure Developer CLI.Local Development Setup:
docs/2-run-locally.md
to include a note on using the Azure Developer CLI to populate environment variables.appreg_setup.sh
script for creating app registrations in Entra ID for local development.Documentation Updates:
appreg_setup.ps1
andappreg_setup.sh
scripts for creating app registrations.Code Enhancements:
src/features/auth-page/auth-api.ts
to dynamically set theisAdmin
property based on a list of admin emails.