Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Key deprecation policy. #194

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions governance/policies/settings-policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
"description": "Key Management Service",
"version": "1.0.0",
"debug": true
},
"keyRotation": {
"gracePeriodDays": 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This policy already exist. See governance/policies/key-rotation-policy.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have not yet integrated the key rotation in the endpoints.

"ttlDays": 7
}
}
}
Expand Down
11 changes: 11 additions & 0 deletions src/policies/Settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,16 @@ export interface IService {
debug: boolean;
}

export interface IKeyRotation {
gracePeriodDays: number;
ttlDays: number;
}


// Define the ISettings interface
export interface ISettings {
service: IService;
keyRotation: IKeyRotation;
}

export class Settings {
Expand All @@ -34,6 +41,10 @@ export class Settings {
version: "1.0.0",
debug: false,
},
keyRotation: {
gracePeriodDays: 2,
ttlDays: 7,
},
};
}

Expand Down