Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node 20 runtime and package versions #207

Open
wants to merge 3 commits into
base: releases/3.x
Choose a base branch
from

Conversation

qianz2
Copy link

@qianz2 qianz2 commented Aug 18, 2023

Task description

Update the azure-pipelines-tool-lib itself to support the Node20 runtime.

Changelog

  • Create a new release branch releases/3.x, bump up dependencies package versions.
  • Updated pipeline to use Node 20
  • Updated dev dependencies
  • Updated node 20 version in test.

@qianz2 qianz2 requested review from a team as code owners August 18, 2023 21:49
Comment on lines 37 to 38
"@types/shelljs": "^0.8.4",
"@types/xml2js": "^0.4.5",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to ensure that the devDependencies in package.json are bumped up as needed?

@qianz2
Copy link
Author

qianz2 commented Aug 18, 2023

Do we need to do anything with this AGENT_VERSION?
process.env['AGENT_VERSION'] = '2.115.0';

process.env['AGENT_VERSION'] = '2.115.0';

@@ -1,6 +1,6 @@
{
"name": "azure-pipelines-tool-lib",
"version": "2.0.4",
"version": "3.0.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should start from the preview version as we did with the node16 migration

@DmitriiBobreshev
Copy link
Contributor

Do we need to do anything with this AGENT_VERSION? process.env['AGENT_VERSION'] = '2.115.0';

process.env['AGENT_VERSION'] = '2.115.0';

Probably not, it's needed for the tests itself

@qianz2
Copy link
Author

qianz2 commented Sep 29, 2023

The changes in this PR is tentative, all migrated tasks are working well without bumping and upgrading this tool-lib, same as for the task-lib microsoft/azure-pipelines-task-lib#962 that I initiated, we've planned to create release branches and check changes to master, but they're not blocking the migration as far as I know. So I will hold it for now, eventually we'll check it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants