Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OneDeploy endpoint for AzureRmWebAppDeployment #279

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dannysongg
Copy link

Add the logic to send deployment requests to the OneDeploy API for AzureRmWebAppDeployment to consume.

@dannysongg dannysongg requested review from manolerazvan and a team as code owners February 9, 2024 19:05
@PhilipsonJoseph
Copy link
Contributor

@dannysongg we could see the test pipelines are in failed status and also there is an conflict in one of the file can you check it once ?

@dannysongg dannysongg force-pushed the users/dannysong/enable-onedeploy branch from 31002d5 to f84a1f4 Compare March 8, 2024 01:46
@dannysongg
Copy link
Author

@PhilipsonJoseph pipelines pass now and conflict is resolved

@v-mohithgc
Copy link
Contributor

v-mohithgc commented Mar 8, 2024

Hi @dannysongg , in order for these changes to be shipped, its required to bump the package version.
Please bump the package version to 3.237.0 in package and package-loc.json file, run build (Inside package folder build it with npm i && npm run build) and commit the changes. Rest all LGTM.

@v-mohithgc
Copy link
Contributor

v-mohithgc commented Mar 12, 2024

Hi @dannysongg , looks like PR checks are failing due to some issue with local npm.
I have created a PR similar to this #294, please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants