Show warnings for Agents that run on OS versions not supported by .NET 8

src/Agent.Listener/Agent.Listener.csproj

@@ -28,7 +28,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <None Update="net6.json">
+    <None Update="net8.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
   </ItemGroup>

src/Agent.Listener/SelfUpdater.cs

@@ -154,41 +154,6 @@ private async Task<bool> UpdateNeeded(string targetVersion, CancellationToken to
                 return false;
             }
 
-            //Checking if current system support .NET 6 agent
-            if (agentVersion.Major == 2 && serverVersion.Major == 3)
-            {
-                Trace.Verbose("Checking if your system supports .NET 6");
-
-                try
-                {
-                    string systemId = PlatformUtil.GetSystemId();
-                    SystemVersion systemVersion = PlatformUtil.GetSystemVersion();
-
-                    Trace.Verbose($"The system you are running on: \"{systemId}\" ({systemVersion})");
-
-                    if (await PlatformUtil.DoesSystemPersistsInNet6Whitelist())
-                    {
-                        // Check version of the system
-                        if (!await PlatformUtil.IsNet6Supported())
-                        {
-                            Trace.Warning($"The operating system the agent is running on is \"{systemId}\" ({systemVersion}), which will not be supported by the .NET 6 based v3 agent. Please upgrade the operating system of this host to ensure compatibility with the v3 agent. See https://aka.ms/azdo-pipeline-agent-version");
-                            return false;
-                        }
-                    }
-                    else
-                    {
-                        Trace.Warning($"The operating system the agent is running on is \"{systemId}\" ({systemVersion}), which has not been tested with the .NET 6 based v3 agent. The v2 agent wil not automatically upgrade to the v3 agent. You can manually download the .NET 6 based v3 agent from https://github.com/microsoft/azure-pipelines-agent/releases. See https://aka.ms/azdo-pipeline-agent-version");
-                        return false;
-                    }
-
-                    Trace.Verbose("The system persists in the list of systems supporting .NET 6");
-                }
-                catch (Exception ex)
-                {
-                    Trace.Error($"Error has occurred while checking if system supports .NET 6: {ex}");
-                }
-            }
-
             if (serverVersion.CompareTo(agentVersion) > 0)
             {
                 return true;

src/Agent.Listener/net6.json → src/Agent.Listener/net8.json

@@ -3,7 +3,7 @@
     "id": "alpine",
     "versions": [
       {
-        "name": "3.13+"
+        "name": "3.17+"
       }
     ]
   },
@@ -12,126 +12,119 @@
     "versions": [
       {
         "name": "2"
-      }
-    ]
-  },
-  {
-    "id": "centos",
-    "versions": [
+      },
       {
-        "name": "7+"
+        "name": "2023"
       }
     ]
   },
   {
     "id": "debian",
     "versions": [
       {
-        "name": "10+"
+        "name": "11+"
       }
     ]
   },
   {
     "id": "fedora",
     "versions": [
       {
-        "name": "33+"
+        "name": "39+"
       }
     ]
   },
   {
     "id": "macOS",
     "versions": [
       {
-        "name": "10.15+"
+        "name": "12+"
       }
     ]
   },
   {
     "id": "mariner",
     "versions": [
       {
-        "name": "1.0+"
+        "name": "2.0+"
       }
     ]
   },
   {
     "id": "opensuse-leap",
     "versions": [
       {
-        "name": "15+"
+        "name": "15.5+"
       }
     ]
   },
   {
     "id": "rhel",
     "versions": [
       {
-        "name": "7+"
+        "name": "8+"
       }
     ]
   },
   {
     "id": "sles",
     "versions": [
       {
-        "name": "12.2+"
+        "name": "15+"
       }
     ]
   },
   {
     "id": "ubuntu",
     "versions": [
       {
-        "name": "16.04"
+        "name": "20.04"
+      },
+      {
+        "name": "22.04"
       },
       {
-        "name": "18.04"
+        "name": "23.10"
       },
       {
-        "name": "20.04+"
+        "name": "24.04"
       }
-
     ]
   },
   {
     "id": "Windows Client",
     "versions": [
       {
-        "name": "7",
-        "version": "7601+"
-      },
-      {
-        "name": "8.1"
+        "name": "10",
+        "version": "1607+"
       },
       {
-        "name": "10",
-        "version": "14393+"
+        "name": "11"
       }
     ]
   },
   {
     "id": "Windows Nano Server",
     "versions": [
       {
-        "version": "17763+"
+        "version": "1809+"
       }
     ]
   },
   {
     "id": "Windows Server",
     "versions": [
       {
-        "name": "2012+"
+        "name": "2016+"
       }
     ]
   },
   {
     "id": "Windows Server Core",
     "versions": [
       {
-        "name": "2012+"
+        "name": "2016+"
       }
     ]
   }
-]
+]

src/Agent.Sdk/Knob/AgentKnobs.cs

@@ -381,7 +381,7 @@ public class AgentKnobs
 
         public static readonly Knob AgentFailOnIncompatibleOS = new Knob(
             nameof(AgentFailOnIncompatibleOS),
-            "Allow agent to fail pipelines on incampatible OS",
+            "Allow agent to fail pipelines on incompatible OS",
             new EnvironmentKnobSource("AGENT_FAIL_ON_INCOMPATIBLE_OS"),
             new RuntimeKnobSource("AGENT_FAIL_ON_INCOMPATIBLE_OS"),
             new BuiltInDefaultKnobSource("false"));
@@ -592,11 +592,6 @@ public class AgentKnobs
             new EnvironmentKnobSource("AGENT_DISABLE_DRAIN_QUEUES_AFTER_TASK"),
             new BuiltInDefaultKnobSource("false"));
 
-        public static readonly Knob EnableFetchingNet6List = new Knob(
-            nameof(EnableFetchingNet6List),
-            "Forces the agent to fetch list of .NET 6 supporting systems from server",
-            new EnvironmentKnobSource("AGENT_ENABLE_FETCHING_NET6_LIST"),
-            new BuiltInDefaultKnobSource("false"));
 
         public static readonly Knob EnableResourceUtilizationWarnings = new Knob(
             nameof(EnableResourceUtilizationWarnings),

src/Agent.Sdk/Util/PlatformUtil.cs

@@ -19,14 +19,14 @@
 using Newtonsoft.Json;
 using System.ServiceProcess;
 using Agent.Sdk.Util;
+using System.Collections.Generic;
 
 namespace Agent.Sdk
 {
     public static class PlatformUtil
     {
         private static UtilKnobValueContext _knobContext = UtilKnobValueContext.Instance();
-        private static OperatingSystem[] net6SupportedSystems;
-        private static HttpClient httpClient = new HttpClient();
+        private static Dictionary<string, OperatingSystem[]> netSupportedSystems = new Dictionary<string, OperatingSystem[]>();
 
         private static readonly string[] linuxReleaseFilePaths = new string[2] { "/etc/os-release", "/usr/lib/os-release" };
 
@@ -393,59 +393,36 @@ public static bool UseLegacyHttpHandler
             get => AgentKnobs.UseLegacyHttpHandler.GetValue(_knobContext).AsBoolean();
         }
 
-        private async static Task<OperatingSystem[]> GetNet6SupportedSystems()
+        private async static Task<OperatingSystem[]> GetSupportedSystemsByNetVersion(string netVersion = "net6")
         {
-            string serverFileUrl = "https://raw.githubusercontent.com/microsoft/azure-pipelines-agent/master/src/Agent.Listener/net6.json";
-            string supportOSfilePath = Path.Combine(Path.GetDirectoryName(Assembly.GetEntryAssembly().Location), "net6.json");
-            string supportOSfileContent;
+            string supportOSfilePath = Path.Combine(Path.GetDirectoryName(Assembly.GetEntryAssembly().Location), $"{netVersion}.json");
             bool supportOSfileExists = File.Exists(supportOSfilePath);
 
-            if ((!supportOSfileExists || File.GetLastWriteTimeUtc(supportOSfilePath) < DateTime.UtcNow.AddHours(-1))
-                && AgentKnobs.EnableFetchingNet6List.GetValue(_knobContext).AsBoolean())
+            if (netSupportedSystems != null && netSupportedSystems.ContainsKey(netVersion))
             {
-                HttpResponseMessage response = await httpClient.GetAsync(serverFileUrl);
-                if (!response.IsSuccessStatusCode)
-                {
-                    throw new Exception($"Getting file \"net6.json\" from server failed. Status code: {response.StatusCode}");
-                }
-                supportOSfileContent = await response.Content.ReadAsStringAsync();
-                await File.WriteAllTextAsync(supportOSfilePath, supportOSfileContent);
+                return netSupportedSystems[netVersion];
             }
-            else
-            {
-                if (net6SupportedSystems != null)
-                {
-                    return net6SupportedSystems;
-                }
-
-                if (!supportOSfileExists)
-                {
-                    throw new FileNotFoundException("File with list of systems supporting .NET 6 is absent", supportOSfilePath);
-                }
 
-                supportOSfileContent = await File.ReadAllTextAsync(supportOSfilePath);
+            if (!supportOSfileExists)
+            {
+                throw new FileNotFoundException($"File with list of systems supporting {netVersion} is absent", supportOSfilePath);
             }
 
-            net6SupportedSystems = JsonConvert.DeserializeObject<OperatingSystem[]>(supportOSfileContent);
-            return net6SupportedSystems;
+            string supportOSfileContent = await File.ReadAllTextAsync(supportOSfilePath);
+
+            netSupportedSystems.Add(netVersion, JsonConvert.DeserializeObject<OperatingSystem[]>(supportOSfileContent));
+            return netSupportedSystems[netVersion];
         }
 
-        public async static Task<bool> IsNet6Supported()
+        public async static Task<bool> IsNetVersionSupported(string netVersion)
         {
-            OperatingSystem[] net6SupportedSystems = await GetNet6SupportedSystems();
+            OperatingSystem[] supportedSystems = await GetSupportedSystemsByNetVersion(netVersion);
 
             string systemId = PlatformUtil.GetSystemId();
             SystemVersion systemVersion = PlatformUtil.GetSystemVersion();
-            return net6SupportedSystems.Any((s) => s.Equals(systemId, systemVersion));
+            return supportedSystems.Any((s) => s.Equals(systemId, systemVersion));
         }
 
-        public async static Task<bool> DoesSystemPersistsInNet6Whitelist()
-        {
-            OperatingSystem[] net6SupportedSystems = await GetNet6SupportedSystems();
-            string systemId = PlatformUtil.GetSystemId();
-
-            return net6SupportedSystems.Any((s) => s.Equals(systemId));
-        }
         public static bool DetectDockerContainer()
         {
             bool isDockerContainer = false;

src/Agent.Worker/JobExtension.cs

@@ -75,51 +75,30 @@ public async Task<List<IStep>> InitializeJob(IExecutionContext jobContext, Pipel
                     context.Start();
                     context.Section(StringUtil.Loc("StepStarting", StringUtil.Loc("InitializeJob")));
 
-                    // Check if a system supports .NET 6
                     PackageVersion agentVersion = new PackageVersion(BuildConstants.AgentPackage.Version);
-                    if (agentVersion.Major < 3)
+                    // Check if a system supports .NET 8
+                    try
                     {
-                        try
-                        {
-                            Trace.Verbose("Checking if your system supports .NET 6");
-
-                            string systemId = PlatformUtil.GetSystemId();
-                            SystemVersion systemVersion = PlatformUtil.GetSystemVersion();
-                            string notSupportNet6Message = null;
+                        Trace.Verbose("Checking if your system supports .NET 8");
 
-                            if (await PlatformUtil.DoesSystemPersistsInNet6Whitelist())
-                            {
-                                // Check version of the system
-                                if (!await PlatformUtil.IsNet6Supported())
-                                {
-                                    notSupportNet6Message = $"The operating system the agent is running on is \"{systemId}\" ({systemVersion}), which will not be supported by the .NET 6 based v3 agent. Please upgrade the operating system of this host to ensure compatibility with the v3 agent. See https://aka.ms/azdo-pipeline-agent-version";
-                                    if (AgentKnobs.AgentFailOnIncompatibleOS.GetValue(jobContext).AsBoolean() &&
-                                        !AgentKnobs.AcknowledgeNoUpdates.GetValue(jobContext).AsBoolean())
-                                    {
-                                        throw new UnsupportedOsException(StringUtil.Loc("FailAgentOnUnsupportedOs"));
-                                    }
-                                }
-                            }
-                            else
-                            {
-                                notSupportNet6Message = $"The operating system the agent is running on is \"{systemId}\" ({systemVersion}), which has not been tested with the .NET 6 based v3 agent. The v2 agent wil not automatically upgrade to the v3 agent. You can manually download the .NET 6 based v3 agent from https://github.com/microsoft/azure-pipelines-agent/releases. See https://aka.ms/azdo-pipeline-agent-version";
-                            }
+                        string systemId = PlatformUtil.GetSystemId();
+                        SystemVersion systemVersion = PlatformUtil.GetSystemVersion();
 
-                            if (!string.IsNullOrWhiteSpace(notSupportNet6Message))
-                            {
-                                context.Warning(notSupportNet6Message);
-                            }
-                        }
-                        catch (UnsupportedOsException)
-                        {
-                            throw;
-                        }
-                        catch (Exception ex)
+                        // Check version of the system
+                        if (!await PlatformUtil.IsNetVersionSupported("net8"))
                         {
-                            Trace.Error($"Error has occurred while checking if system supports .NET 6: {ex}");
-                            context.Warning(ex.Message);
+                            context.Warning(StringUtil.Loc("UnsupportedOsVersionByNet8", $"{systemId} {systemVersion}"));
                         }
                     }
+                    catch (UnsupportedOsException)
+                    {
+                        throw;
+                    }
+                    catch (Exception ex)
+                    {
+                        Trace.Error($"Error has occurred while checking if system supports .NET 8: {ex}");
+                        context.Warning(ex.Message);
+                    }
 
                     // Set agent version variable.
                     context.SetVariable(Constants.Variables.Agent.Version, BuildConstants.AgentPackage.Version);
@@ -392,7 +371,7 @@ public async Task<List<IStep>> InitializeJob(IExecutionContext jobContext, Pipel
                     }
 
                     ArgUtil.NotNull(jobContext, nameof(jobContext)); // I am not sure why this is needed, but static analysis flagged all uses of jobContext below this point
-                    // create execution context for all pre-job steps
+                                                                     // create execution context for all pre-job steps
                     foreach (var step in preJobSteps)
                     {
                         if (PlatformUtil.RunningOnWindows && step is ManagementScriptStep)