Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/srkidd/enable stream and file output #4829

Conversation

srkidd
Copy link
Contributor

@srkidd srkidd commented Jun 4, 2024

Since the ADO agent is not currently capable of streaming the log lines live as well as to local filesystem at the same time, this PR added a feature to do this.

  • Added --enablelogoutput command line option
  • Added error output if both --enablelogoutput and --disableloguploads are used
  • Added UTC timestamp to local file log lines in universal time format
  • Updated --help docs for new option

@srkidd
Copy link
Contributor Author

srkidd commented Jun 4, 2024

@microsoft-github-policy-service agree company="Electronic Arts"

@srkidd srkidd closed this Jun 4, 2024
@srkidd srkidd reopened this Jun 4, 2024
@srkidd srkidd marked this pull request as ready for review June 4, 2024 18:33
@srkidd srkidd requested review from a team as code owners June 4, 2024 18:33
@srkidd
Copy link
Contributor Author

srkidd commented Jun 4, 2024 via email

…-output

Users/srkidd/enable stream and file output
Copy link
Contributor

@KonstantinTyukalov KonstantinTyukalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe enableLogOutput is too abstract name and may confuse people, e.g. they'll think that without this flag agent will not send logs at all.
What about reStreamLogsToFiles?

src/Agent.Listener/Configuration/ConfigurationManager.cs Outdated Show resolved Hide resolved
@KonstantinTyukalov
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Commenter does not have sufficient privileges for PR 4829 in repo microsoft/azure-pipelines-agent

@KonstantinTyukalov
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@srkidd
Copy link
Contributor Author

srkidd commented Jul 3, 2024

@KonstantinTyukalov Is there anything else i need to do to get this to go through?

@srkidd
Copy link
Contributor Author

srkidd commented Jul 23, 2024

@KonstantinTyukalov @qianz2 Just wanted to check up on the status of this PR. Is there something waiting on my end to complete it?

@KonstantinTyukalov
Copy link
Contributor

@srkidd I reopened the PR here to make CI checks pass: #4920
Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants