Added ShellTasksValidation audit action data to issues (#4756)

* Add ShellTasksValidation audit action data to issues * Add validation for issues by knob * Remove knob
microsoft · Jul 18, 2024 · 745922b · 745922b
1 parent b74907b
commit 745922b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/Agent.Worker/Handlers/ProcessHandler/ProcessHandlerHelper.cs b/src/Agent.Worker/Handlers/ProcessHandler/ProcessHandlerHelper.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using Agent.Sdk.Knob;
+using Microsoft.TeamFoundation.DistributedTask.WebApi;
 using Microsoft.VisualStudio.Services.Agent.Util;
 using Microsoft.VisualStudio.Services.Common;
 
@@ -132,7 +133,13 @@ public static (bool, Dictionary<string, object>) ValidateInputArguments(
                     {
                         if (enableAudit && !enableValidation)
                         {
-                            context.Warning(StringUtil.Loc("ProcessHandlerInvalidScriptArgs"));
+                            var issue = new Issue
+                            {
+                                Type = IssueType.Warning,
+                                Message = StringUtil.Loc("ProcessHandlerInvalidScriptArgs"),
+                            };
+                            issue.Data.Add("auditAction", "1"); // ShellTasksValidation = 1
+                            context.AddIssue(issue);
                         }
                         if (enableValidation)
                         {

diff --git a/src/Agent.Worker/Handlers/ProcessHandler/ProcessHandlerV2.cs b/src/Agent.Worker/Handlers/ProcessHandler/ProcessHandlerV2.cs
@@ -2,6 +2,7 @@
 // Licensed under the MIT License.
 
 using Agent.Sdk.Knob;
+using Microsoft.TeamFoundation.DistributedTask.WebApi;
 using Microsoft.VisualStudio.Services.Agent.Util;
 using Newtonsoft.Json;
 using System;
@@ -288,7 +289,13 @@ private void ValidateScriptArgs(
 
                     if (!shouldThrow && enableSecureArgumentsAudit)
                     {
-                        ExecutionContext.Warning(StringUtil.Loc("ProcessHandlerInvalidScriptArgs"));
+                        var issue = new Issue
+                        {
+                            Type = IssueType.Warning,
+                            Message = StringUtil.Loc("ProcessHandlerInvalidScriptArgs"),
+                        };
+                        issue.Data.Add("auditAction", "1"); // ShellTasksValidation = 1
+                        ExecutionContext.AddIssue(issue);
                     }
                 }
                 if (enableTelemetry && telemetry != null)