Add initial OTEL instrumentation logic in imagecustomizer #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cwize1
requested changes
May 29, 2025
cwize1
reviewed
May 29, 2025
cwize1
reviewed
May 29, 2025
aditjha-msft
commented
May 29, 2025
toolkit/tools/pkg/imagecustomizerlib/versionsOfToolDependencies.go
Outdated
Show resolved
Hide resolved
cwize1
requested changes
May 29, 2025
cwize1
requested changes
May 30, 2025
cwize1
previously approved these changes
May 30, 2025
aditjha-msft
force-pushed
the
user/aditjha/instrumentWithOTEL
branch
from
452dd69 to
f103a0a
Compare
cwize1
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for using the OTEL Go sdk to instrument the tool using OTEL standards and practices. It provides initialization logic needed for a global tracer to be used across the tool's execution. For starters, the PR adds a customization time span, with more telemetry to be added in follow up PRs that help with data collection tied to the tool's KPIs.
The PR also adds logic to disable telemetry, and uses a no-op tracer when
--disable-telemetryis passed in. This follows OTEL standardized method of disabling telemetry collection in a clean manner.As part of telemetry initialization, the
telemetry.gofile has been added to set up the OTEL tracer and the OTLP grpc exporter. The exporter will send data to a Python service listening at the local port, which will then forward the data to Azure Monitor.In the effort of splitting up PRs in chunks, the PR for the complement Python telemetry service is here: #249.
Checklist