Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rysweet ensure helloagent in test uses grpc #5497

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

rysweet
Copy link
Collaborator

@rysweet rysweet commented Feb 11, 2025

removing the dependency between tests and sample projects because that got broken too easily

Why are these changes needed?

integration tests used to use the samples - now they are separate

Checks

@rysweet rysweet marked this pull request as draft February 11, 2025 21:09
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (e27f74e) to head (cd3e8b5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5497      +/-   ##
==========================================
+ Coverage   78.17%   78.35%   +0.18%     
==========================================
  Files         167      167              
  Lines        9923     9923              
==========================================
+ Hits         7757     7775      +18     
+ Misses       2166     2148      -18     
Flag Coverage Δ
unittests 78.35% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant