fix: Add deferral to RegisterAgentType and (Add/Remove)Subscription #5494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5494 +/- ##
==========================================
+ Coverage 75.10% 76.46% +1.36%
==========================================
Files 167 205 +38
Lines 9911 11011 +1100
Branches 0 146 +146
==========================================
+ Hits 7444 8420 +976
- Misses 2467 2496 +29
- Partials 0 95 +95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Unlike with the InProcessRuntime, there is a two-phase initialization, first when AgentsApp is built (when initial agents are registered) and when it StartAsync()s and connects to the Gateway. Unfortunately, it is possible to attempt to send direct RPC calls to the Gateway before the message channel is opened; in this case, the Gateway has no connected client corresponding to the RPC's clientId, and falls over. The fix is to defer registering agents and subscriptions with the gateway until after the connection is established after .StartAsync() is called.
lokitoth
force-pushed
the
dev/fix_grpcagentruntime_startup
branch
from
1eb1b87 to
126b07c
Compare
rysweet
approved these changes
Feb 11, 2025
lokitoth
added a commit
that referenced
this pull request
Feb 13, 2025
…registration (#5521) This finishes the fix for the race condition between opening a GrpcWorkerConnection and registering agent types on that worker. Now, instead of failing to register, we return from the call (with the expectation that we will finish registration as we set up the connection) Part 1: #5494 Part 2: #5514 --------- Co-authored-by: Ryan Sweet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike with the InProcessRuntime, there is a two-phase initialization, first when AgentsApp is built (when initial agents are registered) and when it StartAsync()s and connects to the Gateway. Unfortunately, it is possible to attempt to send direct RPC calls to the Gateway before the message channel is opened; in this case, the Gateway has no connected client corresponding to the RPC's clientId, and falls over.
The fix is to defer registering agents and subscriptions with the gateway until after the connection is established after .StartAsync() is called.