Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGS Improvements (Add Test Button in Team Builder View + Others) #5416

Merged
merged 12 commits into from
Feb 7, 2025

Conversation

victordibia
Copy link
Collaborator

@victordibia victordibia commented Feb 7, 2025

Why are these changes needed?

  • Add ability to test teams in Team Builder view
  • Update Gallery (add deep research default team, fix bug with gallery serialization)
  • UI fixes
    • improve drag drop component experience
    • improve new session experience (single click rather than 3 clicks to create a session)
    • fix bug with stop reason not being shown in some cases
Image Image

Related issue number

Closes #5392

Checks

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.11%. Comparing base (73a7ba5) to head (72f7657).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5416   +/-   ##
=======================================
  Coverage   78.11%   78.11%           
=======================================
  Files         158      158           
  Lines        9590     9590           
=======================================
  Hits         7491     7491           
  Misses       2099     2099           
Flag Coverage Δ
unittests 78.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victordibia victordibia requested review from ekzhu and gagb February 7, 2025 18:54
@victordibia victordibia enabled auto-merge (squash) February 7, 2025 20:36
@ekzhu
Copy link
Collaborator

ekzhu commented Feb 7, 2025

@victordibia For the deep research team, I think we can add a planner agent and use a custom selector function so after every other agent, the planner agent is selected to reason the next step. This will make the behavior similar to M1.

@victordibia
Copy link
Collaborator Author

Thats a good idea .. should we create an issue for this, and make it a separate PR?

@victordibia victordibia merged commit 9494ac9 into main Feb 7, 2025
64 checks passed
@victordibia victordibia deleted the ags_updates_vd branch February 7, 2025 23:37
@ekzhu
Copy link
Collaborator

ekzhu commented Feb 8, 2025

Thats a good idea .. should we create an issue for this, and make it a separate PR?

Let's create a separate issue and pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test team button in team builder in AGS.
3 participants