fix(install): unwrap lspServers envelope in plugin .lsp.json (closes #1683)

[sergio-sisternes-epam]

TL;DR

Plugin .lsp.json files using the { "lspServers": { ... } } wrapper format are now correctly unwrapped during install, instead of being silently skipped with a misleading validation error.

Problem

When a plugin ships a .lsp.json using the standard wrapper format:

{
  "lspServers": {
    "my-lsp-server": {
      "command": "my-lsp",
      "args": ["--stdio"],
      "extensionToLanguage": { ".ext": "mylang" }
    }
  }
}

_read_lsp_json() returned the parsed JSON verbatim, causing "lspServers" to be treated as a server name. Its nested dict value (containing the actual servers) was then treated as that server's config -- which lacks a command field, producing:

[!] Skipping invalid LSP server 'lspServers' from plugin 'my-plugin': LSP dependency 'lspServers' requires 'command'

The real LSP servers were never written to .github/lsp.json.

Fix

In _read_lsp_json() (src/apm_cli/deps/plugin_parser.py), after parsing the JSON dict, detect whether it contains a "lspServers" key with a dict value. If so, return the inner dict (the actual server map). The flat format (server names as top-level keys) continues to work unchanged.

This mirrors the envelope handling already used by LSPIntegrator._write_target_config() when writing to Copilot and Claude config files.

Changes

File	Change
src/apm_cli/deps/plugin_parser.py	3-line envelope unwrap + updated docstring
tests/unit/deps/test_plugin_parser_lsp.py	4 new tests

Tests added

• test_unwraps_lsp_servers_envelope -- wrapped format returns inner servers
• test_flat_format_still_works -- flat format regression guard
• test_auto_discovery_with_lsp_servers_wrapper -- auto-discovered .lsp.json with wrapper
• test_wrapped_lsp_json_produces_valid_deps -- end-to-end: wrapped file -> valid deps

Validation

• 20/20 tests pass in tests/unit/deps/test_plugin_parser_lsp.py
• ruff check + ruff format --check clean
• pylint R0801 (duplication) clean

Fixes #1683

[Copilot]

Pull request overview

This PR fixes apm install handling of plugin-provided .lsp.json files by supporting the common { "lspServers": { ... } } wrapper format, so wrapped LSP server definitions are correctly discovered and converted into dependencies instead of being misinterpreted and skipped.

Changes:

• Update _read_lsp_json() to unwrap the "lspServers" envelope when present.
• Expand unit tests to cover wrapped .lsp.json parsing, auto-discovery behavior, and end-to-end conversion into valid LSP dependencies.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/apm_cli/deps/plugin_parser.py	Adds unwrap logic for the "lspServers" envelope and updates the docstring to document both supported formats.
tests/unit/deps/test_plugin_parser_lsp.py	Adds new tests covering wrapped parsing, auto-discovery with wrapper, and end-to-end dependency generation.