feat: support MCP Apps#188
Merged
Merged
Conversation
- Represents MCP servers in customizations and allow their state/ authentication requirements to be reflected. - Breaking: swap `ToolCallBase.clientId` -> `ToolCallBase.contributor` to allow signalling tool calls were triggered by particular MCP servers. - Add additional ToolCallBase._meta note for MCP servers and introduce the `mcp://` protocol channel. This should support all the base features of MCP + MCP Apps, excluding sampling, which is deprecated in the upcoming 2026-07-28 MCP spec and therefore not something I bothered including.
# Conflicts: # CHANGELOG.md # clients/go/CHANGELOG.md # clients/kotlin/CHANGELOG.md # clients/rust/CHANGELOG.md # clients/rust/crates/ahp-types/src/actions.rs # clients/swift/CHANGELOG.md # clients/typescript/CHANGELOG.md # scripts/generate-go.ts # scripts/generate-kotlin.ts # scripts/generate-rust.ts # scripts/generate-swift.ts
# Conflicts: # CHANGELOG.md # clients/go/CHANGELOG.md # clients/kotlin/CHANGELOG.md # clients/rust/CHANGELOG.md # clients/swift/CHANGELOG.md # clients/typescript/CHANGELOG.md
- Rust: box McpServer customization variants and SessionMcpServerStateChanged action payload to satisfy clippy::large_enum_variant (ProtectedResourceMetadata payload pushes McpServerState past the 200-byte budget). - Kotlin: emitKDoc sanitizes nested block-comment delimiters (insert U+200B inside */) so doc strings containing 'tools/*' and 'resources/*' don't close the enclosing /** */ early. - Kotlin reducers: add CustomizationMcpServer branches to the four exhaustive 'when' helpers (id/children/withChildren/withEnabled).
Member
Author
|
This does involve a breaking change, so I will hold off on merging until I have a PR ready in VS Code. In the interim any review would be appreciated. |
dbaeumer
previously approved these changes
Jun 3, 2026
# Conflicts: # clients/rust/crates/ahp-types/src/actions.rs # scripts/generate-rust.ts # types/channels-session/state.ts
sandy081
previously approved these changes
Jun 4, 2026
# Conflicts: # CHANGELOG.md # clients/go/CHANGELOG.md # clients/kotlin/CHANGELOG.md # clients/rust/CHANGELOG.md # clients/swift/CHANGELOG.md # clients/typescript/CHANGELOG.md # types/channels-session/state.ts
Yoyokrazy
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToolCallBase.clientId->ToolCallBase.contributorto allow signalling tool calls were triggered by particular MCP servers.mcp://protocol channel.builds on #182