Skip to content

Python: fix(python): handle function_invocation_configuration in as_agent #5150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saschabuehrle wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

Python: fix(python): handle function_invocation_configuration in as_agent #5150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions python/packages/core/agent_framework/_clients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,8 +646,10 @@ def as_agent(
"tokenizer": tokenizer,
"additional_properties": dict(additional_properties) if additional_properties is not None else None,
}
if function_invocation_configuration is not None:
agent_kwargs["function_invocation_configuration"] = function_invocation_configuration
if function_invocation_configuration is not None and hasattr(self, "function_invocation_configuration"):
client_function_invocation_configuration = getattr(self, "function_invocation_configuration")
if isinstance(client_function_invocation_configuration, dict):
client_function_invocation_configuration.update(function_invocation_configuration)

return Agent(**agent_kwargs)

Expand Down
8 changes: 8 additions & 0 deletions python/packages/core/tests/core/test_clients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,14 @@ def test_base_client_as_agent_uses_explicit_additional_properties(chat_client_ba
assert agent.additional_properties == {"team": "core"}


def test_base_client_as_agent_applies_function_invocation_configuration(
chat_client_base: SupportsChatGetResponse,
) -> None:
chat_client_base.as_agent(function_invocation_configuration={"max_iterations": 8}) # type: ignore[attr-defined]

assert chat_client_base.function_invocation_configuration["max_iterations"] == 8 # type: ignore[attr-defined]


async def test_base_client_get_response_uses_explicit_client_kwargs(chat_client_base: SupportsChatGetResponse) -> None:
async def fake_inner_get_response(**kwargs):
assert kwargs["trace_id"] == "trace-123"
Expand Down