Skip to content

Conversation

@larohra
Copy link
Contributor

@larohra larohra commented Dec 11, 2025

Motivation and Context

Description

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

TaoChenOSU and others added 12 commits December 11, 2025 01:23
…osoft#2738)

* Add factory pattern to concurrent orchestration builder

* Update readme

* Address AI comments

* Fix unit tests

* Fix import

* Prevent multiple calls to set participants or factories

* Add comments

* Mitigate warnings

* Fix mypy

* Address comments

* Address Copilot comments

* Fix tests
…I Structured Outpu… (microsoft#2750)

* fix: ManagerSelectionResponse JSON Schema for OpenAI Structured Output Strict Mode

* refactor: install pre-commit then commit again
* prevent nulls in AIAgent property

* address feedback
* Initial plan

* Add Agent_OpenAI_Step05_Conversation sample for conversation state management

Co-authored-by: rogerbarreto <[email protected]>

* Update Program.cs comment to accurately describe the sample

Co-authored-by: rogerbarreto <[email protected]>

* Update the code to use the ConversationClient more in line with the samples in OpenAI

* Apply suggestions from code review

Co-authored-by: Copilot <[email protected]>

* Changing sample to use ChatClientAgent and conversationId in GetNewThread

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: rogerbarreto <[email protected]>
Co-authored-by: Copilot <[email protected]>
…ft#2777)

---
updated-dependencies:
- dependency-name: AWSSDK.Extensions.Bedrock.MEAI
  dependency-version: 4.0.4.11
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
---
updated-dependencies:
- dependency-name: Azure.Identity
  dependency-version: 1.17.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: Azure.Identity
  dependency-version: 1.17.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: Azure.Identity
  dependency-version: 1.17.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: Azure.Identity
  dependency-version: 1.17.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…eta.5 (microsoft#2778)

---
updated-dependencies:
- dependency-name: Azure.AI.AgentServer.AgentFramework
  dependency-version: 1.0.0-beta.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: Azure.AI.AgentServer.AgentFramework
  dependency-version: 1.0.0-beta.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: Azure.AI.AgentServer.AgentFramework
  dependency-version: 1.0.0-beta.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#2756)

* added more complete parsing for mcp tool arguments

* fixed mypy

* added nonlocal model counter, and some fixes

* fixes in naming logic

* extracted json parsing function, added parametrized test and checked coverage
* Updated package versions

* Small fix
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Chris <[email protected]>
@larohra larohra requested a review from a team as a code owner December 11, 2025 23:25
Copilot AI review requested due to automatic review settings December 11, 2025 23:25
@markwallace-microsoft markwallace-microsoft added documentation Improvements or additions to documentation python .NET workflows Related to Workflows in agent-framework lab Agent Framework Lab labels Dec 11, 2025
@github-actions github-actions bot changed the title Rebase with main .NET: Rebase with main Dec 11, 2025
@github-actions github-actions bot changed the title .NET: Rebase with main Python: Rebase with main Dec 11, 2025
@markwallace-microsoft
Copy link
Member

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
packages/azure-ai/agent_framework_azure_ai
   _chat_client.py4348181%298, 566–567, 569, 572, 575, 578–583, 586, 588, 596, 608–610, 614, 617–618, 626–629, 639, 647–650, 652–653, 655–656, 663, 671–672, 680–681, 686–687, 691–698, 703–704, 712, 718, 726–728, 731, 753–754, 816, 831, 843–847, 874–876, 879–880, 938–943, 964, 1005, 1014, 1040
packages/core/agent_framework
   _mcp.py3395783%105, 109, 169, 178, 242, 252–253, 274, 360, 387, 421–422, 424–432, 434–436, 439–440, 486, 501, 519, 560, 573, 576–577, 581, 591, 615, 618–619, 623, 633, 664, 683, 685, 692–693, 712, 714, 720–723, 740–744, 872
   _tools.py6756590%224, 270, 321, 323, 486, 518–519, 620, 622, 636, 654, 668, 680, 685, 687, 694, 727, 781–783, 821, 844, 846–855, 864–870, 898, 908, 1091, 1464–1468, 1568, 1637, 1738, 1744, 1785–1786, 1918, 1957–1958, 1986–1988, 2023–2024, 2087–2088, 2095–2096
packages/core/agent_framework/_workflows
   _concurrent.py1913681%52, 61–62, 70–71, 90–91, 96, 101, 126, 131, 136–137, 143, 165, 175, 182, 349–353, 355, 383, 439, 451, 480–481, 508, 538, 548, 552–553, 564–566
   _group_chat.py60410782%113, 149, 160, 384–394, 413, 440–441, 446, 508, 522, 529, 533–535, 538, 590–591, 593–595, 619–620, 676–685, 694–695, 698, 743, 757–759, 763, 765–769, 774, 776, 782, 786–788, 793–798, 804, 819, 842, 851, 874, 883, 888–889, 1051, 1070, 1074, 1128, 1178, 1196, 1204, 1229–1231, 1470, 1476, 1635, 1649, 1716–1717, 1719–1720, 1722, 1724, 1726–1727, 1963, 2035–2038, 2048, 2059, 2068–2070
   _workflow_builder.py2903886%259, 596, 694, 700–701, 798–799, 805, 808, 810, 812, 819, 822–826, 828, 892, 959, 969, 1028–1029, 1172, 1186–1193, 1195, 1198, 1200–1202, 1210
packages/core/agent_framework/openai
   _responses_client.py4849480%98, 144, 151–152, 155–156, 161–162, 165, 172, 191, 198, 201–208, 210, 215, 221, 225, 240, 243–244, 246, 273, 303, 331–332, 359, 363, 380, 385, 399, 435, 497, 573, 578, 582–584, 604, 619–620, 624–626, 674, 694–695, 708–709, 725–726, 764, 766, 804, 806, 815–816, 834, 836, 909–917, 934–939, 958, 976, 986, 988, 1006–1007, 1009–1011, 1022–1023, 1026, 1028, 1047
TOTAL16589257284% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
2386 130 💤 0 ❌ 0 🔥 56.724s ⏱️

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request represents a rebase with the main branch, updating the version from 1.0.0b251209 to 1.0.0b251211. It includes several feature additions, bug fixes, and dependency updates across both Python and C# codebases.

Key Changes:

  • Added factory pattern support for concurrent and sequential orchestration builders
  • Enhanced file ID capture from code interpreter in streaming responses
  • Improved MCP tool argument parsing with support for nested objects, typed arrays, and $ref resolution
  • Refactored C# AIAgent.Id property to use protected IdCore pattern with C# 13 field initializer
  • Updated GitHub Actions workflows and package dependencies

Reviewed changes

Copilot reviewed 73 out of 74 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
python/CHANGELOG.md Added changelog entries for version 1.0.0b251211 release
python/pyproject.toml Version bump and dependency updates
python/packages/*/pyproject.toml Consistent version updates across all packages
python/packages/core/pyproject.toml Updated mcp dependency from >=1.13 to >=1.23
python/packages/core/agent_framework/_tools.py Added _build_pydantic_model_from_json_schema for comprehensive JSON schema parsing
python/packages/core/agent_framework/_mcp.py Refactored to use new JSON schema builder
python/packages/core/agent_framework/openai/_responses_client.py Added streaming annotation support for file content
python/packages/core/agent_framework/_workflows/_concurrent.py Added register_participants and register_aggregator factory methods
python/packages/core/agent_framework/_workflows/_workflow_builder.py Enhanced duplicate executor ID detection
python/packages/core/agent_framework/_workflows/_group_chat.py Fixed ManagerSelectionResponse JSON schema for OpenAI strict mode
python/packages/azure-ai/agent_framework_azure_ai/_chat_client.py Added _extract_file_path_contents for code interpreter file handling
python/samples/.../concurrent_participant_factory.py New sample demonstrating participant factory pattern
python/samples/.../handoff_with_code_interpreter_file.py New sample for file generation in handoff workflows
python/samples/.../azure_ai_with_code_interpreter_file_generation.py New samples for both V1 and V2 Azure AI clients
dotnet/src/Microsoft.Agents.AI.Abstractions/AIAgent.cs Refactored Id property to use protected IdCore with field initializer
dotnet/samples/GettingStarted/AgentWithOpenAI/Agent_OpenAI_Step05_Conversation/ New sample demonstrating conversation state management
dotnet/Directory.Packages.props Updated Azure.Identity and AWSSDK.Extensions.Bedrock.MEAI versions
.github/workflows/*.yml Updated actions/checkout from v5 to v6

@eavanvalkenburg eavanvalkenburg changed the title Python: Rebase with main Python: Rebase durable task feature branch with main Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation lab Agent Framework Lab .NET python workflows Related to Workflows in agent-framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants