Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interfaces for "Enhanced UX Notification for Video and Audio Call Feature" #4783
base: main
Are you sure you want to change the base?
Interfaces for "Enhanced UX Notification for Video and Audio Call Feature" #4783
Changes from 6 commits
08d0cee
2e32893
26b0897
fa3a3fd
5969845
cf2d3a2
54eef90
bf24b74
2d8df29
cef43fd
19cdedb
2c7a0e1
1db53b6
86a0c26
cc00d52
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is set to the empty string (note:
String
cannot be null) or an invalid device identifier, I presume your toast will not show anything?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toast will show system default device id as the ticked one if it's null / empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Device validation is performed within the shell code. First, the shell invokes the existing enumerate API to retrieve a list of connected devices. It then compares these devices with those provided by the aforementioned APIs. If a match is found, the device is selected for preview and selected in the list (as shown in last mock image above). Otherwise, 'system default' devices will be displayed for preview and selection.