-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interfaces for "Enhanced UX Notification for Video and Audio Call Feature" #4783
Open
satkh
wants to merge
15
commits into
main
Choose a base branch
from
user/satkh/vidCallFeature_1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
08d0cee
Draft : adding app devices interfaces
satkh 2e32893
implementation for Inotificationproperties2 from udk
satkh 26b0897
Resolving PR comments and Fixed few errors
satkh fa3a3fd
Resolving few more PR comments
satkh 5969845
AppNotificationBuilder changes and tests, fixed tests, contract update
satkh cf2d3a2
AppNotificationBuilder updating contract version for enum
satkh 54eef90
Renaming DevicesData to ConferencingConfig and other changes
satkh bf24b74
Adding containment and other changes as per comments
satkh 2d8df29
Renaming Get/Set SettingType to SettingStyle
satkh cef43fd
Removed velocity, modified issupported, added new tests, telemtry
satkh 19cdedb
Remoed terminal velocity from xml
satkh 2c7a0e1
clean up remaining velocity keys
satkh 1db53b6
Handling rename changes from framework udk
satkh 86a0c26
Fixing contracts version in appnotification idl
satkh cc00d52
Added Feature flag in idl interfaces
satkh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
dev/AppNotifications/AppNotificationConferencingConfig.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
#include "pch.h" | ||
#include "AppNotificationConferencingConfig.h" | ||
#include "Microsoft.Windows.AppNotifications.AppNotificationConferencingConfig.g.cpp" | ||
#include <IsWindowsVersion.h> | ||
|
||
namespace winrt::Microsoft::Windows::AppNotifications::implementation | ||
{ | ||
hstring AppNotificationConferencingConfig::VideoDeviceId() | ||
{ | ||
return m_videoDeviceId; | ||
} | ||
|
||
void AppNotificationConferencingConfig::VideoDeviceId(hstring const& value) | ||
{ | ||
THROW_HR_IF(E_NOTIMPL, !IsCallingPreviewSupported()); | ||
m_videoDeviceId = value; | ||
} | ||
|
||
hstring AppNotificationConferencingConfig::AudioInputDeviceId() | ||
{ | ||
return m_audioInputDeviceId; | ||
} | ||
|
||
void AppNotificationConferencingConfig::AudioInputDeviceId(hstring const& value) | ||
{ | ||
THROW_HR_IF(E_NOTIMPL, !IsCallingPreviewSupported()); | ||
m_audioInputDeviceId = value; | ||
} | ||
|
||
hstring AppNotificationConferencingConfig::AudioOutputDeviceId() | ||
{ | ||
return m_audioOutputDeviceId; | ||
} | ||
|
||
void AppNotificationConferencingConfig::AudioOutputDeviceId(hstring const& value) | ||
{ | ||
THROW_HR_IF(E_NOTIMPL, !IsCallingPreviewSupported()); | ||
m_audioOutputDeviceId = value; | ||
} | ||
|
||
///Checks if the calling preview feature is supported on the current OS version | ||
///TO DO - This method needs implementation on framework UDK, for now it always returns false | ||
satkh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
bool AppNotificationConferencingConfig::IsCallingPreviewSupported() | ||
{ | ||
return false; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
#pragma once | ||
#include "Microsoft.Windows.AppNotifications.AppNotificationConferencingConfig.g.h" | ||
|
||
namespace winrt::Microsoft::Windows::AppNotifications::implementation | ||
{ | ||
struct AppNotificationConferencingConfig : AppNotificationConferencingConfigT<AppNotificationConferencingConfig> | ||
{ | ||
AppNotificationConferencingConfig() = default; | ||
|
||
// Getters | ||
hstring VideoDeviceId(); | ||
hstring AudioInputDeviceId(); | ||
hstring AudioOutputDeviceId(); | ||
|
||
// Setters | ||
void VideoDeviceId(hstring const& value); | ||
void AudioInputDeviceId(hstring const& value); | ||
void AudioOutputDeviceId(hstring const& value); | ||
|
||
static bool IsCallingPreviewSupported(); | ||
|
||
private: | ||
|
||
hstring m_videoDeviceId{}; | ||
hstring m_audioInputDeviceId{}; | ||
hstring m_audioOutputDeviceId{}; | ||
}; | ||
} | ||
namespace winrt::Microsoft::Windows::AppNotifications::factory_implementation | ||
{ | ||
struct AppNotificationConferencingConfig : AppNotificationConferencingConfigT<AppNotificationConferencingConfig, implementation::AppNotificationConferencingConfig> | ||
{ | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These APIs should "do nothing" if calling preview is unsupported. Allow the caller to set/read the value, but don't use it in any way. And don't throw. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But how do we inform the user that this feature is not yet supported when they call these APIs?