Add a WPF sample app that uses WinAppSDK #334
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| ## WpfWithIslandApp | ||
|
|
||
| This app demonstrates how to add a WinAppSDK island to a WPF app. | ||
|
|
||
| The WPF app was converted to an MSIX packaged app. The **AppPackaging.wapproj** project accomplishes this. [More info here](https://learn.microsoft.com/en-us/windows/msix/desktop/desktop-to-uwp-packaging-dot-net). | ||
|
|
||
| Look for the token `Changed_from_original_app` to see what changes were made to the project file to pull in **WindowsAppSDK**. | ||
|
|
||
|
|
||
|
|
||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,9 +4,9 @@ | |
| <OutputType>WinExe</OutputType> | ||
|
|
||
| <!-- | ||
| Changed_from_original_app | ||
| The lowest version of Windows that WinAppSDK supports is 17763. | ||
| But Lottie requires Windows 10.0.19041.0 or higher, so we target this one. | ||
| --> | ||
| <TargetFramework>net8.0-windows10.0.19041.0</TargetFramework> | ||
|
|
||
|
|
@@ -15,21 +15,27 @@ | |
| <UseWPF>true</UseWPF> | ||
|
|
||
| <!-- | ||
| Changed_from_original_app | ||
| Set RuntimeIdentifiers explicitly to portable RIDs. | ||
| Set the Platforms property as well. We don't support AnyCPU because WinAppSDK contains native code. | ||
| --> | ||
| <RuntimeIdentifiers>win-x64;win-x86;win-arm64</RuntimeIdentifiers> | ||
| <Platforms>x64;x86;ARM64</Platforms> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <!-- | ||
| Changed_from_original_app: These packages are required for Lottie. | ||
| FIX BEFORE COMPLETING PR: These packages aren't currently publicly available. | ||
| --> | ||
| <PackageReference Include="CommunityToolkit.WinAppSDK.LottieIsland" Version="0.1.1-prerelease.2" /> | ||
|
There was a problem hiding this comment. @JesseCol, can you check with Geoffrey whether this is the correct Lottie NuGet package that he's assembled? |
||
| <PackageReference Include="CommunityToolkit.WinUI.Lottie" Version="8.0.230818-rc-FHL.4.gb41d8fdcc0" /> | ||
|
There was a problem hiding this comment. Same here. We don't want to pull in WinUI Lottie, just WinAppSDK. |
||
| <PackageReference Include="LottieWinRT" Version="0.1.1-prerelease.1" /> | ||
| <PackageReference Include="Microsoft.Graphics.Win2D" Version="1.2.0" /> | ||
|
|
||
| <!-- | ||
| Changed_from_original_app: Pull in WinAppSDK. | ||
| --> | ||
| <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240404000" /> | ||
| </ItemGroup> | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JesseCol, WinAppSDK Lottie only requires RS5 (the same as the rest of WASDK). Let's follow-up on this one.