Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Introducing the "Onboarding scenarios" folder to support the new "How-tos" node in our conceptual TOC #264

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MatchaMatch
Copy link

@MatchaMatch MatchaMatch commented Oct 20, 2022

Description

The Windows docs team is currently experimenting with the introduction of a scenarios-oriented How-Tos node in our conceptual TOC:

image

Context and rationale are detailed in a design doc.

This PR includes the source code that supports the WIP "How to build a Hello World app" how-to, previewable here. Here's the accompanying PR for the how-to doc.

Target Release

n/a

Checklist

  • Samples build and run using the Visual Studio versions listed in the Windows development docs.
  • Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
  • Samples set the minimum supported OS version to Windows 10 version 1809.
  • Samples build clean with no warnings or errors.
  • [For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
  • If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
  • I have commented on my PR /azp run SamplesCI-<FeatureName> to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.

@MatchaMatch
Copy link
Author

cc @asklar - this is a WIP but I wanted to get this on your radar sooner rather than later in case you have any feedback on the broad strokes (of either the sample or the accompanying how-to linked from the PR description)🙏


<Identity
Name="0384fbb5-95aa-45a8-822f-e7f3a4bdbb6f"
Publisher="CN=mikben"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to review the Samples repo guidelines to determine if/how PII like this should be handled (ideally removed).

@@ -0,0 +1 @@
This solution provides the source code that corresponds to our WIP "How to build a Hello World WinUI 3 app" how-to.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to review the Samples repo guidelines and apply README templating (if it exists).

@asklar
Copy link
Member

asklar commented Oct 21, 2022

@codendone and @MikeHillberg to take a look

@MatchaMatch MatchaMatch marked this pull request as ready for review October 27, 2022 17:50
@MatchaMatch MatchaMatch marked this pull request as draft October 27, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants