Firefly driver: Postpone variable definitions until first use #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forderud
force-pushed
the
postpone-variable
branch
from
d8ecf0e
to
3dda5a4
Compare
forderud
force-pushed
the
postpone-variable
branch
from
3dda5a4
to
4c8f0b6
Compare
forderud
force-pushed
the
postpone-variable
branch
from
4c8f0b6
to
399d78d
Compare
|
I closed this PR unintentionally. I apologize. I am reopening the PR. |
forderud
force-pushed
the
postpone-variable
branch
from
399d78d
to
e15a7b0
Compare
Motivation: * Improves readability and maintainability. * Have been supported since C99. * Can potentially reduce stack size usage when variables are confined to a local scope. Downside: * It's a bit more cumbersome to manually determine the stack size of a function when all local variables are no longer listed together. However, tools can still do this effectively.
forderud
force-pushed
the
postpone-variable
branch
from
e15a7b0
to
de92011
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
usageandusageLengthvariables in hid/firefly/driver/vfeature.c. The compiler is probably already optimizing this though.Downside: