CI Pipelines build with WDK Nuget Packages #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobL-MSFT
reviewed
Jun 13, 2024
JakobL-MSFT
reviewed
Jun 13, 2024
JakobL-MSFT
approved these changes
Jun 14, 2024
JakobL-MSFT
added a commit
that referenced
this pull request
Jun 28, 2024
* Memory leakage in message
"sizeof(SCANNER_MESSAGE) * threadCount * requestCount" bytes long memory is allocated but only "sizeof(SCANNER_MESSAGE) * threadCount" bytes long of it is freed.
* Handles malloc function fail case
* Refactors comment line
* Solves the miscalculation of the message index
* simbatt: Fix broken registry read-back
The GetSimBattStateFromRegistry function is currently using default settings if GetSimBattStateFromRegistry succeeds, whereas settings from registry are only applied if GetSimBattStateFromRegistry fails. This does not make sense to me.
Therefore proposing to remove the `!` negation from `if (!NT_SUCCESS(Status)) {` on the line after `Status = GetSimBattStateFromRegistry(Device, RegState);` so that default settings are loaded when registry read-back fails.
* Issue of freeing memory without waiting completion of threads accessing it is fixed
* Fixes information leakage warning
Fixes the issue of possible information leakage from uninitialized padding bytes
* Avoids possible multiplication overflow warning
* Avoids possible multiplication overflow warning
* CI Pipelines build with WDK Nuget Packages (#1179)
Integrate nuget into the workflow pipelines
* FI from main to develop (#1188)
Fix text and minor issues in Winget configuration files
Co-authored-by: Adonais Romero Gonzalez <[email protected]>
* Improve version info, vsix installation, and update building locally readme
* Fix printing vsix version
* Refactored vsix install and cleaned up build sampleset
---------
Co-authored-by: İsa Yurdagül <[email protected]>
Co-authored-by: Fredrik Orderud <[email protected]>
Co-authored-by: Christian Allred <[email protected]>
Co-authored-by: tristanb-ntdev <[email protected]>
Co-authored-by: Matt <[email protected]>
Co-authored-by: Adonais Romero Gonzalez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the WDK now supporting Nuget packages for ease of install it is beneficial to have the CI pipeline also utilize this ability. This will allow easier and faster integration when new WDK versions are published without relying on the runner images to be updated.
Pipeline Time Metrics
BuildAll (push and pull_request)
Without Vsix Install: ~08m 59s
With Vsix Install: ~38m 59s (optimized ~8m)
CodeQL (push and pull_request)
Without Vsix Install: ~1h 1m 43s
With Vsix Install: ~1h 34m 31s (optimized ~1h 16m 2s)
Average WDK Vsix Install Time
~21m (optimized ~15s)
Average WDK Nuget Restore
~1m 30s