Pchahar/pc load letter6 #1116
Open
Pchahar/pc load letter6 #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#752) 1. Running the ApiValidator and make sure the issue free. 2. Running the InfVerif and make sure the INF file issue free. There is limitations for MSFT currently doesn’t have any SDIO based WI-FI NICs, so the latest Driver Verifier /RC 33 36 tests not run
…LONG (#754) fix UINT8 comparison with ULONG
* Include/Needs inbox services * Added header comment specifying required minimum OS version
…errors (#793) * Clean up some misc infverif 1203 errors * Clean up some infverif 1324 (no PnpLockdown=1) errors
…evelopBranch Hopefully fix develop branch error in these header files
…630) drivers. (#803) * fix driver isolation violations 1322 1323 for netvmini60.inf * fix driver isolation violations 1322 1323 for netvmini620.inf * fix driver isolation violations 1322 1323 for netvmini630.inf * change local type from ULONG to UINT8 to match return type * Remove AddReg TextModeFlags in inf for netvmini60 * Remove AddReg TextModeFlags in inf for netvmini620 * Remove AddReg TextModeFlags in inf for netvmini630
* add NDIS_SUPPORT_NDIS680 in #if directive in adapter.c * add NDIS_SUPPORT_NDIS680 in #if directive in miniport.c * fix driver isolation violation 1323 for netvmini680.inf * fix driver isolation violation 1322 for netvmini680.inf * set NIC_PHYSICAL_MEDIUM to NdisPhysicalMedium802_3 in hardware.h * change local type from ULONG to UINT8 to match return type * Remove AddReg TextModeFlags in inf for netvmini680
Co-authored-by: Jason Knichel <[email protected]>
Co-authored-by: Jason Knichel <[email protected]>
Co-authored-by: Jason Knichel <[email protected]>
Update ProdScan and WiaDriver samples to target a single architecture.
#825) * Update BthEchoSampleCli and BthEchoSampleSrv to be single architecture targeted and the specific build architecture is stamped at the time it is built. * Remove long deprecated WDF coinstaller references. Rename CopyFiles section from Drivers_Dir to DriverStore_Dir. Revert TargetOSVersion for the Models sections to NT$ARCH$...1, the same as before without my changes. * Address more PR feedbacks and update README.md. Co-authored-by: Hongwei Qi <[email protected]>
…st practices (#837) * Update TestMcro sample to target a single architecture. * Update copywia.cmd to use the new path for the TestMcro.inf file. * Restore missing BOM to vcxproj file.
Create Test.txt
…use new build flags (#1078) * Fixes for sample build errors * Fix additional sample * Add additional sample * Updated comments in Build-Sample.ps1 * Adjusting exclusions.csv to be accurate for GE. Still issues for NI that we need to understand better * Merge from develop branch * Merge from develop branch * Merge from develop branch * Delete WPD samples * Separate infverif additional options for old vs new WDK * Delete WPD samples entry in our CODEOWNERS file * Fix spelling error * For 22621 WDK Remove the /samples flag --------- Co-authored-by: Zac Lockard <[email protected]> Co-authored-by: Jakob Lichtenberg (170957) <[email protected]>
user/jakobl/delete_AvsCameraDMFT_sln
* add prm sample * Update exclusions.csv * add owners for PRM and GPIO samples * fix INF --------- Co-authored-by: Yinghan Yang (307315) <[email protected]> Co-authored-by: JakobL-MSFT <[email protected]>
fix INF target OS for Ge only PRM sample Co-authored-by: Yinghan Yang (307315) <[email protected]>
…on VS2022 (#1089) * ddproxy compiles on VS2022 * inspect compiles on VS2022 * stmEdit compiles on VS2022 * sampler compiles on VS2022 * changes some encodings and updates the stmedit version * restores the vcxproj * more vcxproj fixes * ddproxy inf * stmedit vcxproj pt2 * stmd sln * Update exclusions.csv * all but one flavor compiles on NI EWDK * found a bug in an assert * Builds clean for all drivers except WfpSampler on both WDK 17.1.5 and 17.8.2, WFPSampler changes get it to build on WDK 17.1.5 but there are still issues with 17.8.2 --------- Co-authored-by: Elaine Houha <[email protected]> Co-authored-by: JakobL-MSFT <[email protected]>
…th NI WDK but still broken for GE WDK
…1098) * test code scanning with new package * update code scanning file. test without building * fix typo * add back build step * Update Code-Scanning.yml * Update Code-Scanning.yml * Update Code-Scanning.yml
* Add parent directory file for NuGet import support * fix directory.build.props file * Checked in a comment with baseline. Also small fix to make sure we use GE InfVerif flags and Exclusions.csv * Remove references to path which refer older vars * Remove stale variable path from mincore.lib * remove references to stale variale from vhidmimium * remove stale reference from ddproxy * remove stale reference in inspect.vcxproj * Remove stale path reference in msnmntr.vcxproj * Remove stale path reference to stmedit.vcxproj * Remove stale path from echosrv.vcxproj * remove stale path mscorelib SingleComponentSingleStateUm.vcxproj * remove stale path * Move GitHub check up front * Replace correct value for the wpprecorderum * Removed the stale references for the um libs * correct the reference path for libs simplemedia * Correct the reference path for vccomsup * Correct the reference path for sdk lib path * added reference to the kit shared inc path * added reference to the kit shared inc path * Build-SampleSet: Let determination of NuGet packages be based on a folder .\packages rather than the .\packages.config file * added reference to the kit shared inc path * Updated PACKAGERESTORE_README.md with results from Prashant's recent fixes. Moves us 37 failures to 19 failures. * Rewrite how to get NuGet packages via EEAP or MSFTNuGet * Minor edits to Building-Locally.md * added reference to the kit shared inc path * Move forward to ge_release 26052. This fixes samples .\prm * added reference to the kit shared inc path * Move forward to ge_release 26052. This fixes samples .\prm. Update to .\Building-Locally.md * added reference to the kit shared inc path * added reference to the kit shared inc path * added reference to the kit shared inc path * added reference to the kit shared inc path * added reference to the kit shared inc path * added reference to the kit shared inc path * Update NuGet build instructions and PACKAGERESTORE_README.md * Reset Building-Locally.md and remote PACKAGERESTORE_README.md --------- Co-authored-by: Prashant Chahar <[email protected]> Co-authored-by: Jakob Lichtenberg <[email protected]>
* Add parent directory file for NuGet import support * fix directory.build.props file * Checked in a comment with baseline. Also small fix to make sure we use GE InfVerif flags and Exclusions.csv * Remove references to path which refer older vars * Remove stale variable path from mincore.lib * remove references to stale variale from vhidmimium * remove stale reference from ddproxy * remove stale reference in inspect.vcxproj * Remove stale path reference in msnmntr.vcxproj * Remove stale path reference to stmedit.vcxproj * Remove stale path from echosrv.vcxproj * remove stale path mscorelib SingleComponentSingleStateUm.vcxproj * remove stale path * Move GitHub check up front * Replace correct value for the wpprecorderum * Removed the stale references for the um libs * correct the reference path for libs simplemedia * Correct the reference path for vccomsup * Correct the reference path for sdk lib path * added reference to the kit shared inc path * added reference to the kit shared inc path * Build-SampleSet: Let determination of NuGet packages be based on a folder .\packages rather than the .\packages.config file * added reference to the kit shared inc path * Updated PACKAGERESTORE_README.md with results from Prashant's recent fixes. Moves us 37 failures to 19 failures. * Rewrite how to get NuGet packages via EEAP or MSFTNuGet * Minor edits to Building-Locally.md * added reference to the kit shared inc path * Move forward to ge_release 26052. This fixes samples .\prm * added reference to the kit shared inc path * Move forward to ge_release 26052. This fixes samples .\prm. Update to .\Building-Locally.md * added reference to the kit shared inc path * added reference to the kit shared inc path * added reference to the kit shared inc path * added reference to the kit shared inc path * added reference to the kit shared inc path * added reference to the kit shared inc path * Update NuGet build instructions and PACKAGERESTORE_README.md * Reset Building-Locally.md and remote PACKAGERESTORE_README.md * Add reference to wdk um include path * Add reference to wdk um include path * Add reference to wdk um include path * Provided full path to wmimofck.exe to correctly resolve * Fix the path resolution for wmimofexe * Correct the wmimfck path resolution * Add NuGet arm64 support --------- Co-authored-by: Prashant Chahar <[email protected]> Co-authored-by: Jakob Lichtenberg <[email protected]>
* user/jakobl/simplify_flags * user/jakobl/simplify_flags * Update Build-Sample.ps1 * Merge with upcoming PR #1088 * white space only change
* Add arch variable to simsensor and simtc infs * Update models section to user $ARCH$ variable
* compiles on both EWDKs needed for all 5 Samples * fixes the debug build which broke during merge conflict resolution * Update exclusions.csv --------- Co-authored-by: Elaine Houha <[email protected]> Co-authored-by: JakobL-MSFT <[email protected]>
User/daspr/correct idd sample
…1109) * Remove wmicheck for mof as it is not valid for kmdf projects * Fixed path to uuid.lib --------- Co-authored-by: Prashant Chahar <[email protected]>
Update to WDK NuGet 26061 Co-authored-by: Jakob Lichtenberg <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // | ||
| // Create one on one mapping | ||
| // | ||
| for (ULONG ulIndex = 0; ulIndex < m_InPins.size(); ulIndex++) |
Check failure
Code scanning / CodeQL
Comparison of narrow type with wide type in loop condition Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit flag for arm64 for ehsc and remove incremental link as ehsc is not passsed for ARM64 VS and looks like ltcg is not supported as well.