Skip to content

Adding cool down period for specific executors #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.0.12
2.0.13
16 changes: 15 additions & 1 deletion src/VirtualClient/VirtualClient.Actions/FIO/FioExecutor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,18 @@ public string CommandLine
this.Parameters[nameof(DiskWorkloadExecutor.CommandLine)] = value;
}
}


/// <summary>
/// The Cool down period for Virtual Client Component.
/// </summary>
public TimeSpan CoolDownPeriod
{
get
{
return this.Parameters.GetTimeSpanValue(nameof(this.CoolDownPeriod), TimeSpan.FromSeconds(0));
}
}

/// <summary>
/// Defines the job files specified in the profile.
/// </summary>
Expand Down Expand Up @@ -377,6 +388,9 @@ await this.DeleteTestFilesAsync(workload.TestFiles)
.ConfigureAwait(false);
}
}

// TO DO: Remove once we have Loop Executor.
await this.WaitAsync(this.CoolDownPeriod, cancellationToken);
}

if (!string.IsNullOrEmpty(this.JobFiles))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,17 @@ public int? ConnectionsPerThread
}
}

/// <summary>
/// The Cool down period for Virtual Client Component.
/// </summary>
public TimeSpan CoolDownPeriod
{
get
{
return this.Parameters.GetTimeSpanValue(nameof(this.CoolDownPeriod), TimeSpan.FromSeconds(0));
}
}

/// <summary>
/// Parameter defines the differentiator for which to convey the number of interrupts in the workload toolset tests.
/// </summary>
Expand Down Expand Up @@ -619,6 +630,10 @@ await this.ExecuteServerAsync(telemetryContext, cancellationToken)
{
throw new NotSupportedException($"The role: {this.Role} is not supported.");
}

// TO DO: Remove once we have Loop Executor.
await this.WaitAsync(this.CoolDownPeriod, cancellationToken);

}

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,17 @@ public StressNgExecutor(IServiceCollection dependencies, IDictionary<string, ICo
this.fileSystem = this.systemManagement.FileSystem;
}

/// <summary>
/// The Cool down period for Virtual Client Component.
/// </summary>
public TimeSpan CoolDownPeriod
{
get
{
return this.Parameters.GetTimeSpanValue(nameof(this.CoolDownPeriod), TimeSpan.FromSeconds(0));
}
}

/// <summary>
/// The command line argument defined in the profile.
/// </summary>
Expand Down Expand Up @@ -84,6 +95,9 @@ protected override async Task ExecuteAsync(EventContext telemetryContext, Cancel
}
}
}

// TO DO: Remove once we have Loop Executor.
await this.WaitAsync(this.CoolDownPeriod, cancellationToken);
}

/// <summary>
Expand Down
Loading