Handle tuple rest parameters in legacy decorator arity checks - #64164
Merged
Jake Bailey (jakebailey) merged 1 commit intoSep 4, 2026
Merged
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Copilot started reviewing on behalf of
Mateusz Burzyński (Andarist)
September 4, 2026 07:02
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The fix and regression baselines were fully reviewed with no unresolved issues.
Pull request overview
Corrects legacy decorator arity checks for tuple-typed rest parameters.
Changes:
- Uses effective parameter counts for decorator arity checks.
- Adds regression coverage and expected baselines.
File summaries
| File | Description |
|---|---|
tsc/testdata/tests/cases/compiler/decoratorRestNoCrash1.ts |
Adds regression coverage. |
tsc/testdata/baselines/reference/compiler/decoratorRestNoCrash1.types |
Records inferred types. |
tsc/testdata/baselines/reference/compiler/decoratorRestNoCrash1.symbols |
Records resolved symbols. |
tsc/testdata/baselines/reference/compiler/decoratorRestNoCrash1.errors.txt |
Confirms expected diagnostics. |
tsc/internal/checker/checker.go |
Corrects decorator arity calculation. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Jake Bailey (jakebailey)
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, the test sample reports:
That is not correct here.
This PR relates to a closed issue that reported a crash (see here), Corsa no longer crashes but I noticed now it doesn't quite report correct errors here so I decided to put out this PR for it