fix(58145): suppress jsdoc for private members - #64106
Open
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
Open
fix(58145): suppress jsdoc for private members#64106Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Oleksandr Tarasiuk (a-tarasyuk)
August 31, 2026 05:38
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Suppresses JSDoc from type-erased private class members during declaration emit.
Changes:
- Adds comment suppression for private properties, methods, and accessors.
- Adds regression coverage and updates declaration baselines.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tsc/internal/transformers/declarations/transform.go |
Suppresses comments on emitted private members. |
tsc/testdata/tests/cases/compiler/declarationEmitPrivateMemberComments.ts |
Tests TypeScript and JavaScript private members. |
tsc/testdata/baselines/reference/compiler/declarationEmitPrivateMemberComments.js |
Captures declaration output. |
tsc/testdata/baselines/reference/compiler/declarationEmitPrivateMemberComments.symbols |
Captures symbol output. |
tsc/testdata/baselines/reference/compiler/declarationEmitPrivateMemberComments.types |
Captures type output. |
tsc/testdata/baselines/reference/compiler/jsDeclarationEmitPrivateStaticMethod.js |
Updates private static method output. |
tsc/testdata/baselines/reference/compiler/declFileMethods(target=es2015).js |
Removes private method comments. |
tsc/testdata/baselines/reference/compiler/declFileAccessors(target=es2015).js |
Removes private accessor comments. |
tsc/testdata/baselines/reference/compiler/declarationEmitPrivateAsyncMethod.js |
Removes private async method comments. |
tsc/testdata/baselines/reference/compiler/commentsClassMembers(target=es2015).js |
Updates private member comment output. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
fix/58145
branch
from
August 31, 2026 05:53
4f78fab to
b8ca9ac
Compare
Copilot started reviewing on behalf of
Oleksandr Tarasiuk (a-tarasyuk)
August 31, 2026 06:18
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58145