Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -316,17 +316,23 @@ jobs:
working-directory: ./pr

- run: npm ci
id: base-npm-ci
continue-on-error: true
working-directory: ./base

- run: npx hereby lkg
working-directory: ./pr

- run: npx hereby lkg
id: base-lkg
continue-on-error: true
if: ${{ steps.base-npm-ci.outcome == 'success' }}
working-directory: ./base

- run: |
echo "See $GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID for more info."
node ./pr/scripts/checkPackageSize.mjs ./base ./pr >> $GITHUB_STEP_SUMMARY
if: ${{ steps.base-lkg.outcome == 'success' }}

misc:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion src/services/stringCompletions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ function getStringLiteralCompletionEntries(sourceFile: SourceFile, node: StringL
const uniques = new Set<string>();
const stringLiteralTypes = concatenate(
getStringLiteralTypes(typeChecker.getContextualType(node, ContextFlags.None), uniques),
getStringLiteralTypes(typeChecker.getContextualType(node, ContextFlags.Completions), uniques),
getStringLiteralTypes(typeChecker.getContextualType(node, ContextFlags.IgnoreNodeInferences), uniques),
);
return toStringLiteralCompletionsFromTypes(stringLiteralTypes);
}
Expand Down
Loading