Skip to content

Fix reverse mapped contextual this inference leak #62839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
learn-dumboo24 wants to merge 1 commit into from
Closed

Fix reverse mapped contextual this inference leak #62839

learn-dumboo24 wants to merge 1 commit into from
+54,041 −53,969

Conversation

@learn-dumboo24
Copy link

@learn-dumboo24 learn-dumboo24 commented Dec 4, 2025 

Fixes #62779

 ## Summary
 - skip reverse-mapped apparent types when computing contextual `this`
 - add regression test `reverseMappedTypeParameterLeak`

 ## Testing
 - npx gulp runtests --tests reverseMappedTypeParameterLeak

@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Dec 4, 2025
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Dec 4, 2025
@learn-dumboo24
Copy link
Author

learn-dumboo24 commented Dec 4, 2025

@microsoft-github-policy-service agree

@jakebailey
Copy link
Member

jakebailey commented Dec 4, 2025

You completely broke checker.ts; I'm not sure what this PR is.

@jakebailey jakebailey closed this Dec 4, 2025
@github-project-automation github-project-automation bot moved this from Not started to Done in PR Backlog Dec 4, 2025
@learn-dumboo24
Copy link
Author

learn-dumboo24 commented Dec 4, 2025

I am extremely sorry, day before yesterday I pulled for latest changes and tested on local it I thought it worked but again sorry sir @jakebailey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@learn-dumboo24 @jakebailey @typescript-bot