Skip to content

Ahborkhuja:fix-private-method #62393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ahborkhuja wants to merge 2 commits into from
Closed

Ahborkhuja:fix-private-method #62393

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84d084f
Ahborkhuja:fix-private-method
Ahborkhuja Sep 4, 2025
8de7432
formated for dprint
Ahborkhuja Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 36 additions & 3 deletions src/services/codefixes/fixAddMissingMember.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,11 +564,44 @@ function getActionsForMissingMethodDeclaration(context: CodeFixContext, info: Ty
}

const methodName = token.text;
const shouldBePrivateByDefault = methodName.startsWith("_");
const addMethodDeclarationChanges = (modifierFlags: ModifierFlags) => textChanges.ChangeTracker.with(context, t => addMethodDeclaration(context, t, call, token, modifierFlags, parentDeclaration, declSourceFile));
const actions = [createCodeFixAction(fixMissingMember, addMethodDeclarationChanges(modifierFlags & ModifierFlags.Static), [modifierFlags & ModifierFlags.Static ? Diagnostics.Declare_static_method_0 : Diagnostics.Declare_method_0, methodName], fixMissingMember, Diagnostics.Add_all_missing_members)];
if (modifierFlags & ModifierFlags.Private) {
actions.unshift(createCodeFixActionWithoutFixAll(fixMissingMember, addMethodDeclarationChanges(ModifierFlags.Private), [Diagnostics.Declare_private_method_0, methodName]));

// Create the main action - private by default for underscore methods
const defaultModifierFlags = shouldBePrivateByDefault ? (modifierFlags | ModifierFlags.Private) : modifierFlags;

const actions = [createCodeFixAction(
fixMissingMember,
addMethodDeclarationChanges(defaultModifierFlags), // Remove the & ModifierFlags.Static
[
shouldBePrivateByDefault ? Diagnostics.Declare_private_method_0 :
(modifierFlags & ModifierFlags.Static ? Diagnostics.Declare_static_method_0 : Diagnostics.Declare_method_0),
methodName,
],
fixMissingMember,
Diagnostics.Add_all_missing_members,
)];

// Only add additional options if the default isn't already private
if ((modifierFlags & ModifierFlags.Private) || methodName.startsWith("_")) {
// For underscore methods, add a regular (non-private) option
if (shouldBePrivateByDefault) {
actions.push(createCodeFixActionWithoutFixAll(
fixMissingMember,
addMethodDeclarationChanges(modifierFlags & ~ModifierFlags.Private), // Remove private flag
[modifierFlags & ModifierFlags.Static ? Diagnostics.Declare_static_method_0 : Diagnostics.Declare_method_0, methodName],
));
}
else {
// For non-underscore methods with private flag, add private option
actions.unshift(createCodeFixActionWithoutFixAll(
fixMissingMember,
addMethodDeclarationChanges(ModifierFlags.Private),
[Diagnostics.Declare_private_method_0, methodName],
));
}
}

return actions;
}

Expand Down
Loading