You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR says it fixes #56497, but that's not entirely the case; #56497 is asking for rename to not introduce foo as foo at all, whereas this PR adds a new suggestion that complains about foo as foo. That's a fine suggestion, but I would expect a PR that fixes #56497 to fix rename, and IIRC there's something odd about the way renaming works that may prevent that from working (but I can't remember what it was; I've wanted to fix this issue previously but gave up due to some issue...).
@jakebailey, understood. I came to a similar conclusion when trying to get rename to not include the redundancy. Would it be acceptable to create a new issue to close via this PR? Because, this PR has a lightweight band-aid "fix" for a non code-breaking bug. If not, do you have any insight/suggestion on fixing rename itself?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56497