Improve relationship check for mapped type sources under exactOptionalPropertyTypes
#60890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Dec 31, 2024
| @@ -12337,7 +12337,24 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker { | |||
| } | |||
|
|
|||
| function getNonMissingTypeOfSymbol(symbol: Symbol) { | |||
Contributor
Author
There was a problem hiding this comment.
This is used by isPropertySymbolTypeRelated, the problem is that - at times - the instantiated mapped symbol is still deferred~ and is an indexed access type. When that happens, this function can't remove the missing type because it's not yet there.
To accommodate that, I clone the indexed access types resulting from that mapped symbol intantiation with a new AccessFlags.NonMissing so when the constraint of that indexed access gets finally requested the missing type can still be removed from it, like this code here intended to.
Andarist
force-pushed
the
fix/mapped-types-eopt-constraints
branch
from
2f33b46 to
f62d72a
Compare
Contributor
Contributor
Author
|
I don't think so, see #60233 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #60233