Skip to content

fix(60617): abstract modifier cannot be used with private a identifier #60627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
a-tarasyuk wants to merge 1 commit into from
Closed

fix(60617): abstract modifier cannot be used with private a identifier #60627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51414,10 +51414,6 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
return grammarErrorOnNode(modifier, Diagnostics._0_modifier_must_precede_1_modifier, "abstract", "accessor");
}
}
if (isNamedDeclaration(node) && node.name.kind === SyntaxKind.PrivateIdentifier) {
return grammarErrorOnNode(modifier, Diagnostics._0_modifier_cannot_be_used_with_a_private_identifier, "abstract");
}

flags |= ModifierFlags.Abstract;
break;

Expand Down
5 changes: 1 addition & 4 deletions tests/baselines/reference/privateNamesIncompatibleModifiers.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,11 @@ privateNamesIncompatibleModifiers.ts(25,5): error TS1031: 'declare' modifier can
privateNamesIncompatibleModifiers.ts(26,5): error TS1031: 'declare' modifier cannot appear on class elements of this kind.
privateNamesIncompatibleModifiers.ts(27,5): error TS1042: 'async' modifier cannot be used here.
privateNamesIncompatibleModifiers.ts(28,5): error TS1042: 'async' modifier cannot be used here.
privateNamesIncompatibleModifiers.ts(32,5): error TS18019: 'abstract' modifier cannot be used with a private identifier.
privateNamesIncompatibleModifiers.ts(32,14): error TS1267: Property '#quux' cannot have an initializer because it is marked abstract.


!!! error TS2318: Cannot find global type 'AsyncIterableIterator'.
==== privateNamesIncompatibleModifiers.ts (23 errors) ====
==== privateNamesIncompatibleModifiers.ts (22 errors) ====
class A {
public #foo = 3; // Error
~~~~~~
Expand Down Expand Up @@ -100,8 +99,6 @@ privateNamesIncompatibleModifiers.ts(32,14): error TS1267: Property '#quux' cann

abstract class B {
abstract #quux = 3; // Error
~~~~~~~~
!!! error TS18019: 'abstract' modifier cannot be used with a private identifier.
~~~~~
!!! error TS1267: Property '#quux' cannot have an initializer because it is marked abstract.
}
Expand Down