-
Notifications
You must be signed in to change notification settings - Fork 13.2k
add missing interfaces for sub-classes of PerformanceEntry #59166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sujal Gupta <[email protected]>
|
@microsoft-github-policy-service agree |
|
I have now found that I might need to add interfaces in webworker.generated.d.ts because the issue is not resolved yet. |
|
I just found that some entry types are not supported by |
…orted types Signed-off-by: Sujal Gupta <[email protected]>
…l/TypeScript into bug-fix-getEntriesByType
|
@RyanCavanaugh The issue is still not solved, can you please help me with this? |
Fixes #58644
The interface were missing for subclasses of
PerformanceEntrywhich causes an error when we try to run below code snippet Playground LinkI have added missing interfaces for different subclasses for every return type which can be found here. All of them inherit from
PerformanceEntryinterface.I found that some interfaces were missing some properties. For example PerformanceResourceTiming.initiatorType
I think there are still changes that needs to be done. Thanks @lll000111 for guiding me.
Please provide feedback.