Fixed regression in signature instantiation #59121

Andarist · 2024-07-02T22:16:02Z

Andarist · 2024-07-02T22:19:40Z

src/compiler/checker.ts


    function createSignatureTypeMapper(signature: Signature, typeArguments: readonly Type[] | undefined): TypeMapper {
-        return createTypeMapper(signature.typeParameters!, typeArguments);
+        return createTypeMapper(map(signature.typeParameters!, tp => tp.mapper ? instantiateType(tp, tp.mapper) : tp), typeArguments);


The problem is that the signature might already be a product of instantiateSignature that was called without eraseTypeParameters and which thus cloned type parameters. Those cloned parameters are instantiated there in the arguments list using the available mapper but the same mapper wasn't later used when erasing type parameters from that result. This led to the mapper-instantiated cloned type parameter being left non-instantiated after erasing type parameters.

Not 100% certain, but it may be better to do sameMap here just because that would avoid extra arrays when nothing actually needs to be mapped (but maybe it doesn't happen that often).

sure, I pushed out a commit to use sameMap here

andrewbranch · 2024-07-05T21:22:39Z

@typescript-bot test it

typescript-bot · 2024-07-05T21:22:43Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-07-05T21:42:58Z

Hey @andrewbranch, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-07-05T21:53:52Z

@andrewbranch Here are the results of running the user tests with tsc comparing main and refs/pull/59121/merge:

Everything looks good!

typescript-bot · 2024-07-05T22:05:12Z

@andrewbranch
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,353k (± 0.10%)}	_{192,273k (± 0.07%)}	_~	_192,178k	_192,559k	_{p=0.810 n=6}
_{Parse Time}	_{1.31s (± 0.79%)}	_{1.30s (± 0.93%)}	_~	_1.28s	_1.31s	_{p=0.720 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.42s (± 0.34%)}	_{9.42s (± 0.36%)}	_~	_9.38s	_9.46s	_{p=0.936 n=6}
_{Emit Time}	_{2.76s (± 0.74%)}	_{2.73s (± 1.13%)}	_~	_2.70s	_2.78s	_{p=0.199 n=6}
_{Total Time}	_{14.20s (± 0.20%)}	_{14.17s (± 0.29%)}	_~	_14.12s	_14.22s	_{p=0.293 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,360k (± 0.00%)}	_{1,218,632k (± 0.00%)}	_{+272k (+ 0.02%)}	_1,218,568k	_1,218,699k	_{p=0.005 n=6}
_{Parse Time}	_{6.66s (± 0.84%)}	_{6.65s (± 0.40%)}	_~	_6.62s	_6.69s	_{p=1.000 n=6}
_{Bind Time}	_{1.87s (± 0.40%)}	_{1.87s (± 0.59%)}	_~	_1.85s	_1.88s	_{p=0.604 n=6}
_{Check Time}	_{30.65s (± 0.41%)}	_{30.61s (± 0.20%)}	_~	_30.51s	_30.68s	_{p=0.419 n=6}
_{Emit Time}	_{13.54s (± 0.33%)}	_{13.54s (± 0.44%)}	_~	_13.45s	_13.62s	_{p=1.000 n=6}
_{Total Time}	_{52.71s (± 0.31%)}	_{52.67s (± 0.20%)}	_~	_52.52s	_52.84s	_{p=0.688 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,130,140	_2,130,140	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,634	_927,634	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,106,235k (± 0.00%)}	_{2,106,438k (± 0.00%)}	_{+203k (+ 0.01%)}	_2,106,355k	_2,106,546k	_{p=0.008 n=6}
_{Parse Time}	_{6.60s (± 0.33%)}	_{6.61s (± 0.39%)}	_~	_6.58s	_6.65s	_{p=0.622 n=6}
_{Bind Time}	_{2.32s (± 0.86%)}	_{2.31s (± 0.59%)}	_~	_2.28s	_2.32s	_{p=0.532 n=6}
_{Check Time}	_{70.66s (± 1.15%)}	_{70.65s (± 0.21%)}	_~	_70.52s	_70.88s	_{p=0.173 n=6}
_{Emit Time}	_{0.14s (± 2.95%)}	_{0.13s (± 3.10%)}	_{🟩-0.01s (- 4.82%)}	_0.13s	_0.14s	_{p=0.034 n=6}
_{Total Time}	_{79.72s (± 1.01%)}	_{79.70s (± 0.19%)}	_~	_79.56s	_79.93s	_{p=0.148 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,497	_1,225,500	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,459	_261,460	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,341,317k (± 0.03%)}	_{2,341,823k (± 0.02%)}	_~	_2,341,408k	_2,342,996k	_{p=0.173 n=6}
_{Parse Time}	_{5.04s (± 1.20%)}	_{5.04s (± 1.50%)}	_~	_4.93s	_5.13s	_{p=0.936 n=6}
_{Bind Time}	_{1.92s (± 0.51%)}	_{1.93s (± 0.79%)}	_~	_1.90s	_1.94s	_{p=0.344 n=6}
_{Check Time}	_{34.26s (± 0.70%)}	_{34.16s (± 0.40%)}	_~	_33.95s	_34.32s	_{p=0.336 n=6}
_{Emit Time}	_{2.64s (± 2.38%)}	_{2.63s (± 3.57%)}	_~	_2.56s	_2.81s	_{p=0.470 n=6}
_{Total Time}	_{43.87s (± 0.52%)}	_{43.77s (± 0.41%)}	_~	_43.54s	_43.98s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,497	_1,225,500	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,459	_261,460	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,415,367k (± 0.04%)}	_{2,415,583k (± 0.02%)}	_~	_2,414,909k	_2,416,419k	_{p=0.471 n=6}
_{Parse Time}	_{6.27s (± 0.60%)}	_{6.26s (± 0.91%)}	_~	_6.16s	_6.31s	_{p=1.000 n=6}
_{Bind Time}	_{2.02s (± 0.85%)}	_{2.02s (± 0.97%)}	_~	_2.00s	_2.06s	_{p=0.739 n=6}
_{Check Time}	_{40.66s (± 0.24%)}	_{40.73s (± 0.13%)}	_~	_40.67s	_40.81s	_{p=0.173 n=6}
_{Emit Time}	_{3.17s (± 2.10%)}	_{3.14s (± 2.28%)}	_~	_3.05s	_3.26s	_{p=0.470 n=6}
_{Total Time}	_{52.12s (± 0.31%)}	_{52.17s (± 0.23%)}	_~	_52.02s	_52.29s	_{p=0.575 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,195	_258,198	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,737	_104,738	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{427,466k (± 0.00%)}	_{427,804k (± 0.01%)}	_{+338k (+ 0.08%)}	_427,771k	_427,845k	_{p=0.005 n=6}
_{Parse Time}	_{3.28s (± 0.63%)}	_{3.29s (± 0.71%)}	_~	_3.26s	_3.32s	_{p=0.514 n=6}
_{Bind Time}	_{1.33s (± 0.31%)}	_{1.33s (± 1.03%)}	_~	_1.30s	_1.34s	_{p=0.753 n=6}
_{Check Time}	_{17.83s (± 0.45%)}	_{17.84s (± 0.40%)}	_~	_17.76s	_17.94s	_{p=0.872 n=6}
_{Emit Time}	_{1.24s (± 0.66%)}	_{1.26s (± 0.83%)}	_~	_1.24s	_1.27s	_{p=0.078 n=6}
_{Total Time}	_{23.69s (± 0.27%)}	_{23.72s (± 0.41%)}	_~	_23.58s	_23.85s	_{p=0.630 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,535k (± 0.02%)}	_{369,790k (± 0.03%)}	_{+255k (+ 0.07%)}	_369,588k	_369,901k	_{p=0.013 n=6}
_{Parse Time}	_{3.46s (± 0.55%)}	_{3.44s (± 0.70%)}	_~	_3.40s	_3.46s	_{p=0.331 n=6}
_{Bind Time}	_{1.93s (± 0.76%)}	_{1.95s (± 1.01%)}	_~	_1.93s	_1.98s	_{p=0.286 n=6}
_{Check Time}	_{19.13s (± 0.24%)}	_{19.14s (± 0.20%)}	_~	_19.09s	_19.19s	_{p=0.572 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.52s (± 0.24%)}	_{24.53s (± 0.25%)}	_~	_24.47s	_24.63s	_{p=0.688 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,882,038	_2,882,038	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,696	_975,696	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,045,281k (± 0.00%)}	_{3,046,629k (± 0.00%)}	_{+1,349k (+ 0.04%)}	_3,046,536k	_3,046,691k	_{p=0.005 n=6}
_{Parse Time}	_{16.87s (± 0.29%)}	_{16.89s (± 0.57%)}	_~	_16.80s	_17.07s	_{p=1.000 n=6}
_{Bind Time}	_{5.08s (± 1.83%)}	_{5.06s (± 0.32%)}	_~	_5.03s	_5.07s	_{p=0.870 n=6}
_{Check Time}	_{90.04s (± 2.20%)}	_{90.46s (± 3.24%)}	_~	_88.19s	_94.59s	_{p=0.936 n=6}
_{Emit Time}	_{27.94s (± 6.70%)}	_{27.54s (± 8.73%)}	_~	_24.44s	_29.52s	_{p=0.936 n=6}
_{Total Time}	_{139.93s (± 0.23%)}	_{139.94s (± 0.42%)}	_~	_139.21s	_140.94s	_{p=0.810 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,544k (± 0.03%)}	_{411,767k (± 0.02%)}	_{+223k (+ 0.05%)}	_411,701k	_411,892k	_{p=0.005 n=6}
_{Parse Time}	_{4.68s (± 0.42%)}	_{4.70s (± 0.29%)}	_~	_4.69s	_4.72s	_{p=0.059 n=6}
_{Bind Time}	_{2.09s (± 0.52%)}	_{2.08s (± 0.71%)}	_~	_2.06s	_2.10s	_{p=0.186 n=6}
_{Check Time}	_{20.79s (± 0.41%)}	_{20.79s (± 0.19%)}	_~	_20.74s	_20.85s	_{p=0.630 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.57s (± 0.31%)}	_{27.57s (± 0.17%)}	_~	_27.52s	_27.62s	_{p=0.747 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,784k (± 0.05%)}	_{463,167k (± 0.09%)}	_~	_462,672k	_463,587k	_{p=0.229 n=6}
_{Parse Time}	_{3.18s (± 0.65%)}	_{3.18s (± 0.71%)}	_~	_3.14s	_3.21s	_{p=0.934 n=6}
_{Bind Time}	_1.17s	_{1.17s (± 0.84%)}	_~	_1.16s	_1.19s	_{p=1.000 n=6}
_{Check Time}	_{17.93s (± 0.46%)}	_{17.89s (± 0.36%)}	_~	_17.84s	_18.02s	_{p=0.687 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.27s (± 0.44%)}	_{22.25s (± 0.31%)}	_~	_22.17s	_22.37s	_{p=0.748 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-05T23:17:18Z

@andrewbranch Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59121/merge:

Everything looks good!

andrewbranch · 2024-07-09T18:36:31Z

@typescript-bot cherry-pick to release-5.5

typescript-bot · 2024-07-09T18:36:36Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick to release-5.5`	✅ Started	✅ Results

typescript-bot · 2024-07-09T18:38:53Z

Hey, @andrewbranch! I've created #59204 for you.

…e-5.5 (#59204) Co-authored-by: Mateusz Burzyński <[email protected]>

Fixed regression in signature instantiation

e722c83

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 2, 2024

Andarist commented Jul 2, 2024

View reviewed changes

andrewbranch assigned weswigham Jul 5, 2024

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 5, 2024

use sameMap

f03f859

weswigham approved these changes Jul 9, 2024

View reviewed changes

weswigham merged commit c9dd98e into microsoft:main Jul 9, 2024

Andarist deleted the fix/sig-erasing-instantiation branch July 9, 2024 18:35

typescript-bot pushed a commit that referenced this pull request Jul 9, 2024

Fixed regression in signature instantiation (#59121)

d96dd00

typescript-bot mentioned this pull request Jul 9, 2024

🤖 Pick PR #59121 (Fixed regression in signature insta...) into release-5.5 #59204

Merged

DanielRosenwasser pushed a commit that referenced this pull request Jul 16, 2024

🤖 Pick PR #59121 (Fixed regression in signature insta...) into releas…

cf167db

…e-5.5 (#59204) Co-authored-by: Mateusz Burzyński <[email protected]>

DanielRosenwasser added this to the TypeScript 5.5.4 milestone Jul 16, 2024

This was referenced Aug 1, 2024

React's ComponentProps type issues in TypeScript 5.5.4 #59490

Closed

Fixed regression in generic signature instantiation with default type args #59510

Merged

sandersn removed this from PR Backlog Apr 22, 2025

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Fixed regression in signature instantiation #59121

Fixed regression in signature instantiation #59121

Uh oh!

Conversation

Andarist commented Jul 2, 2024

Uh oh!

Andarist Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

jakebailey Jul 8, 2024

Choose a reason for hiding this comment

Uh oh!

Andarist Jul 9, 2024

Choose a reason for hiding this comment

Uh oh!

andrewbranch commented Jul 5, 2024

Uh oh!

typescript-bot commented Jul 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 5, 2024

Uh oh!

typescript-bot commented Jul 5, 2024

Uh oh!

typescript-bot commented Jul 5, 2024

tsc

Uh oh!

typescript-bot commented Jul 5, 2024

Uh oh!

andrewbranch commented Jul 9, 2024

Uh oh!

typescript-bot commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

typescript-bot commented Jul 5, 2024 •

edited

Loading

typescript-bot commented Jul 9, 2024 •

edited

Loading