Improve inference for a tuple target with 2 middle variadic elements and implied arity for the latter #56976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and implied arity for the latter
typescript-bot
added
the
For Uncommitted Bug
Andarist
commented
Jan 8, 2024
| inferFromTypes(sliceTupleType(source, startLength, endLength + sourceArity - targetInfo.impliedArity), elementTypes[startLength]); | ||
| inferFromTypes(sliceTupleType(source, startLength + targetInfo.impliedArity, endLength), elementTypes[startLength + 1]); | ||
| } | ||
| else if ((targetInfo = getInferenceInfoForType(elementTypes[startLength + 1]))?.impliedArity !== undefined) { |
Contributor
Author
There was a problem hiding this comment.
TODO: I might have to limit this to fixed-sized sources or something. This requires more test cases to exercise the improved behavior. It would help me slightly if I'd have a playground with this build - @jakebailey would you mind creating one? :)
…ariadic-elements # Conflicts: # tests/baselines/reference/variadicTuples3.symbols # tests/baselines/reference/variadicTuples3.types # tests/cases/conformance/types/tuple/variadicTuples3.ts
typescript-bot
added
For Backlog Bug
Member
|
@typescript-bot pack this |
Collaborator
Collaborator
|
Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #56970