Skip to content

Update URL & Request & XMLHttpRequest interface to accept Location #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adam Naji (Bashamega) wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Update URL & Request & XMLHttpRequest interface to accept Location #2552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
587901f
Update URL interface to accept Location type in constructor and metho…
Bashamega Sep 7, 2026
a20ff24
update
Bashamega Sep 7, 2026
ed0def1
Update URL constructor signature to include Location type across mult…
Bashamega Sep 7, 2026
a2b7b8e
update
Bashamega Sep 7, 2026
1d50041
Refactor URL interface to remove Location type from constructor and m…
Bashamega Sep 7, 2026
956f2d4
Update Request constructor to include Location type across multiple b…
Bashamega Sep 10, 2026
72209e0
Update fetch method signature to include Location type across multipl…
Bashamega Sep 10, 2026
b0bf0fe
Refactor Request constructor to simplify additionalTypes declaration …
Bashamega Sep 10, 2026
1144edb
Update multiple baseline files to include WorkerLocation type in Requ…
Bashamega Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31227,7 +31227,7 @@ interface Request extends Body {

declare var Request: {
prototype: Request;
new(input: RequestInfo | URL, init?: RequestInit): Request;
new(input: RequestInfo | Location | URL, init?: RequestInit): Request;
};

/**
Expand Down Expand Up @@ -38143,13 +38143,13 @@ interface URL {

declare var URL: {
prototype: URL;
new(url: string | URL, base?: string | URL): URL;
new(url: string | URL | Location, base?: string | URL | Location): URL;
/**
* The **`URL.canParse()`** static method of the URL interface returns a boolean indicating whether or not an absolute URL, or a relative URL combined with a base URL, are parsable and valid.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/canParse_static)
*/
canParse(url: string | URL, base?: string | URL): boolean;
canParse(url: string | URL | Location, base?: string | URL | Location): boolean;
/**
* The **`createObjectURL()`** static method of the URL interface creates a string containing a blob URL pointing to the object given in the parameter.
*
Expand All @@ -38161,7 +38161,7 @@ declare var URL: {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/parse_static)
*/
parse(url: string | URL, base?: string | URL): URL | null;
parse(url: string | URL | Location, base?: string | URL | Location): URL | null;
/**
* The **`revokeObjectURL()`** static method of the URL interface releases an existing object URL which was previously created by calling URL.createObjectURL().
*
Expand Down Expand Up @@ -42559,7 +42559,7 @@ interface WindowOrWorkerGlobalScope {
createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/fetch) */
fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
fetch(input: RequestInfo | Location | URL, init?: RequestInit): Promise<Response>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/queueMicrotask) */
queueMicrotask(callback: VoidFunction): void;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/reportError) */
Expand Down Expand Up @@ -42865,8 +42865,8 @@ interface XMLHttpRequest extends XMLHttpRequestEventTarget {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/XMLHttpRequest/open)
*/
open(method: string, url: string | URL): void;
open(method: string, url: string | URL, async: boolean, username?: string | null, password?: string | null): void;
open(method: string, url: string | URL | Location): void;
open(method: string, url: string | URL | Location, async: boolean, username?: string | null, password?: string | null): void;
/**
* The XMLHttpRequest method **`overrideMimeType()`** specifies a MIME type other than the one provided by the server to be used instead when interpreting the data being transferred in a request.
*
Expand Down Expand Up @@ -44997,7 +44997,7 @@ declare function clearTimeout(id: number | undefined): void;
declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/fetch) */
declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
declare function fetch(input: RequestInfo | Location | URL, init?: RequestInit): Promise<Response>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/queueMicrotask) */
declare function queueMicrotask(callback: VoidFunction): void;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/reportError) */
Expand Down
12 changes: 6 additions & 6 deletions baselines/serviceworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8465,7 +8465,7 @@ interface Request extends Body {

declare var Request: {
prototype: Request;
new(input: RequestInfo | URL, init?: RequestInit): Request;
new(input: RequestInfo | WorkerLocation | URL, init?: RequestInit): Request;
};

/**
Expand Down Expand Up @@ -9517,19 +9517,19 @@ interface URL {

declare var URL: {
prototype: URL;
new(url: string | URL, base?: string | URL): URL;
new(url: string | URL | WorkerLocation, base?: string | URL | WorkerLocation): URL;
/**
* The **`URL.canParse()`** static method of the URL interface returns a boolean indicating whether or not an absolute URL, or a relative URL combined with a base URL, are parsable and valid.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/canParse_static)
*/
canParse(url: string | URL, base?: string | URL): boolean;
canParse(url: string | URL | WorkerLocation, base?: string | URL | WorkerLocation): boolean;
/**
* The **`URL.parse()`** static method of the URL interface returns a newly created URL object representing the URL defined by the parameters.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/parse_static)
*/
parse(url: string | URL, base?: string | URL): URL | null;
parse(url: string | URL | WorkerLocation, base?: string | URL | WorkerLocation): URL | null;
};

/**
Expand Down Expand Up @@ -12577,7 +12577,7 @@ interface WindowOrWorkerGlobalScope {
createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/fetch) */
fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
fetch(input: RequestInfo | WorkerLocation | URL, init?: RequestInit): Promise<Response>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/queueMicrotask) */
queueMicrotask(callback: VoidFunction): void;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/reportError) */
Expand Down Expand Up @@ -13529,7 +13529,7 @@ declare function clearTimeout(id: number | undefined): void;
declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/fetch) */
declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
declare function fetch(input: RequestInfo | WorkerLocation | URL, init?: RequestInit): Promise<Response>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/queueMicrotask) */
declare function queueMicrotask(callback: VoidFunction): void;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/reportError) */
Expand Down
16 changes: 8 additions & 8 deletions baselines/sharedworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8048,7 +8048,7 @@ interface Request extends Body {

declare var Request: {
prototype: Request;
new(input: RequestInfo | URL, init?: RequestInit): Request;
new(input: RequestInfo | WorkerLocation | URL, init?: RequestInit): Request;
};

/**
Expand Down Expand Up @@ -9048,13 +9048,13 @@ interface URL {

declare var URL: {
prototype: URL;
new(url: string | URL, base?: string | URL): URL;
new(url: string | URL | WorkerLocation, base?: string | URL | WorkerLocation): URL;
/**
* The **`URL.canParse()`** static method of the URL interface returns a boolean indicating whether or not an absolute URL, or a relative URL combined with a base URL, are parsable and valid.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/canParse_static)
*/
canParse(url: string | URL, base?: string | URL): boolean;
canParse(url: string | URL | WorkerLocation, base?: string | URL | WorkerLocation): boolean;
/**
* The **`createObjectURL()`** static method of the URL interface creates a string containing a blob URL pointing to the object given in the parameter.
*
Expand All @@ -9066,7 +9066,7 @@ declare var URL: {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/parse_static)
*/
parse(url: string | URL, base?: string | URL): URL | null;
parse(url: string | URL | WorkerLocation, base?: string | URL | WorkerLocation): URL | null;
/**
* The **`revokeObjectURL()`** static method of the URL interface releases an existing object URL which was previously created by calling URL.createObjectURL().
*
Expand Down Expand Up @@ -12083,7 +12083,7 @@ interface WindowOrWorkerGlobalScope {
createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/fetch) */
fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
fetch(input: RequestInfo | WorkerLocation | URL, init?: RequestInit): Promise<Response>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/queueMicrotask) */
queueMicrotask(callback: VoidFunction): void;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/reportError) */
Expand Down Expand Up @@ -12503,8 +12503,8 @@ interface XMLHttpRequest extends XMLHttpRequestEventTarget {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/XMLHttpRequest/open)
*/
open(method: string, url: string | URL): void;
open(method: string, url: string | URL, async: boolean, username?: string | null, password?: string | null): void;
open(method: string, url: string | URL | WorkerLocation): void;
open(method: string, url: string | URL | WorkerLocation, async: boolean, username?: string | null, password?: string | null): void;
/**
* The XMLHttpRequest method **`overrideMimeType()`** specifies a MIME type other than the one provided by the server to be used instead when interpreting the data being transferred in a request.
*
Expand Down Expand Up @@ -13219,7 +13219,7 @@ declare function clearTimeout(id: number | undefined): void;
declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/fetch) */
declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
declare function fetch(input: RequestInfo | WorkerLocation | URL, init?: RequestInit): Promise<Response>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/queueMicrotask) */
declare function queueMicrotask(callback: VoidFunction): void;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/reportError) */
Expand Down
16 changes: 8 additions & 8 deletions baselines/ts5.5/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31203,7 +31203,7 @@ interface Request extends Body {

declare var Request: {
prototype: Request;
new(input: RequestInfo | URL, init?: RequestInit): Request;
new(input: RequestInfo | Location | URL, init?: RequestInit): Request;
};

/**
Expand Down Expand Up @@ -38117,13 +38117,13 @@ interface URL {

declare var URL: {
prototype: URL;
new(url: string | URL, base?: string | URL): URL;
new(url: string | URL | Location, base?: string | URL | Location): URL;
/**
* The **`URL.canParse()`** static method of the URL interface returns a boolean indicating whether or not an absolute URL, or a relative URL combined with a base URL, are parsable and valid.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/canParse_static)
*/
canParse(url: string | URL, base?: string | URL): boolean;
canParse(url: string | URL | Location, base?: string | URL | Location): boolean;
/**
* The **`createObjectURL()`** static method of the URL interface creates a string containing a blob URL pointing to the object given in the parameter.
*
Expand All @@ -38135,7 +38135,7 @@ declare var URL: {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/parse_static)
*/
parse(url: string | URL, base?: string | URL): URL | null;
parse(url: string | URL | Location, base?: string | URL | Location): URL | null;
/**
* The **`revokeObjectURL()`** static method of the URL interface releases an existing object URL which was previously created by calling URL.createObjectURL().
*
Expand Down Expand Up @@ -42533,7 +42533,7 @@ interface WindowOrWorkerGlobalScope {
createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/fetch) */
fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
fetch(input: RequestInfo | Location | URL, init?: RequestInit): Promise<Response>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/queueMicrotask) */
queueMicrotask(callback: VoidFunction): void;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/reportError) */
Expand Down Expand Up @@ -42839,8 +42839,8 @@ interface XMLHttpRequest extends XMLHttpRequestEventTarget {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/XMLHttpRequest/open)
*/
open(method: string, url: string | URL): void;
open(method: string, url: string | URL, async: boolean, username?: string | null, password?: string | null): void;
open(method: string, url: string | URL | Location): void;
open(method: string, url: string | URL | Location, async: boolean, username?: string | null, password?: string | null): void;
/**
* The XMLHttpRequest method **`overrideMimeType()`** specifies a MIME type other than the one provided by the server to be used instead when interpreting the data being transferred in a request.
*
Expand Down Expand Up @@ -44971,7 +44971,7 @@ declare function clearTimeout(id: number | undefined): void;
declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/fetch) */
declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
declare function fetch(input: RequestInfo | Location | URL, init?: RequestInit): Promise<Response>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/queueMicrotask) */
declare function queueMicrotask(callback: VoidFunction): void;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/reportError) */
Expand Down
12 changes: 6 additions & 6 deletions baselines/ts5.5/serviceworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8462,7 +8462,7 @@ interface Request extends Body {

declare var Request: {
prototype: Request;
new(input: RequestInfo | URL, init?: RequestInit): Request;
new(input: RequestInfo | WorkerLocation | URL, init?: RequestInit): Request;
};

/**
Expand Down Expand Up @@ -9514,19 +9514,19 @@ interface URL {

declare var URL: {
prototype: URL;
new(url: string | URL, base?: string | URL): URL;
new(url: string | URL | WorkerLocation, base?: string | URL | WorkerLocation): URL;
/**
* The **`URL.canParse()`** static method of the URL interface returns a boolean indicating whether or not an absolute URL, or a relative URL combined with a base URL, are parsable and valid.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/canParse_static)
*/
canParse(url: string | URL, base?: string | URL): boolean;
canParse(url: string | URL | WorkerLocation, base?: string | URL | WorkerLocation): boolean;
/**
* The **`URL.parse()`** static method of the URL interface returns a newly created URL object representing the URL defined by the parameters.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/parse_static)
*/
parse(url: string | URL, base?: string | URL): URL | null;
parse(url: string | URL | WorkerLocation, base?: string | URL | WorkerLocation): URL | null;
};

/**
Expand Down Expand Up @@ -12574,7 +12574,7 @@ interface WindowOrWorkerGlobalScope {
createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/fetch) */
fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
fetch(input: RequestInfo | WorkerLocation | URL, init?: RequestInit): Promise<Response>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/queueMicrotask) */
queueMicrotask(callback: VoidFunction): void;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/reportError) */
Expand Down Expand Up @@ -13526,7 +13526,7 @@ declare function clearTimeout(id: number | undefined): void;
declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/fetch) */
declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
declare function fetch(input: RequestInfo | WorkerLocation | URL, init?: RequestInit): Promise<Response>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/queueMicrotask) */
declare function queueMicrotask(callback: VoidFunction): void;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/reportError) */
Expand Down
Loading