-
Notifications
You must be signed in to change notification settings - Fork 460
Remove StyleMedia #2199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove StyleMedia #2199
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
This is removing StyleMedia not StylePropertyMap, please change the title |
|
React v15 is still using this, it seems. Probably not worth removing? |
|
Yeah, we should try adding it to DT and maybe revisit this later |
|
Can you try to test this since the definitely typed PR was merged? @jakebailey |
|
microsoft/TypeScript#62640 is happy on DT, but causes very odd test failures elsewhere that I need to investigate. |
|
Hello @jakebailey |
|
I think we just are waiting for some time for people to adopt the DT side change |
|
DefinitelyTyped/DefinitelyTyped#73939 was merged a while ago, we can pretty easily tell people to update their types (there are worse breaks coming). |
I have resolved the conflicts, merge it when you are ready |
|
LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Should I be freaking out now?! |
|
Hah, no, I just mean there are other changes already |
Can you test this @jakebailey ?
Sorry for the late PR, I was busy