fix(cell): Relax Global-Shared loader/storer to support all possible tile shape.#47
Closed
lcy-seso wants to merge 19 commits intomicrosoft:masterfrom
Closed
fix(cell): Relax Global-Shared loader/storer to support all possible tile shape.#47lcy-seso wants to merge 19 commits intomicrosoft:masterfrom
lcy-seso wants to merge 19 commits intomicrosoft:masterfrom
Conversation
KuangjuX
reviewed
Jan 25, 2025
Contributor
KuangjuX
left a comment
There was a problem hiding this comment.
I'm a bit curious: when Swizzle is applied only to a single BaseTile, it can complete the swapping process on one block. However, this might render the functionality of Swizzle ineffective. For example, using Swizzle<3, 3, 3> is actually ineffective because it effectively performs the logic of Swizzle<2, 3, 3>. The same logic is executed in the next basic block as well, which can lead to a 4-way bank conflict.
I'd like to hear how you understand this issue @lcy-seso .
04bd051 to
ac15cc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #43 resolve #37 resolve #18 resolve #40
It is not necessary to restrict the tile shape utilized by the loader/storer between global and shared memory. While certain tile shapes may not optimally utilize hardware features when accessing global memory, selecting the most appropriate tile shape can be addressed independently.
I would like to emphasize that swizzling is strictly applied within a BaseTile and will not be applied across BaseTiles.
This pull request relaxes the restrictions on tile shapes used by the loader/storer, allowing all possible tile shapes to be utilized.
Additionally, it aims to improve the implementation by ensuring consistency of all related concepts throughout the codebase.
Tasks: