Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Wrap OpenAIDefaults for Python #2327

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sss04
Copy link
Contributor

@sss04 sss04 commented Dec 13, 2024

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Wrap OpenAIDefaults to work for PySpark, and add URL as a OpenAIDefault.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@sss04 sss04 requested a review from mhamilton723 as a code owner December 13, 2024 22:17
mhamilton723
mhamilton723 previously approved these changes Dec 14, 2024
@mhamilton723
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sss04
Copy link
Contributor Author

sss04 commented Dec 17, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sss04
Copy link
Contributor Author

sss04 commented Dec 20, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sss04
Copy link
Contributor Author

sss04 commented Dec 20, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants