fix: OpenAIChatCompletion class method shouldSkip method to skip row if no user message #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned as there might OpenAIMessages with empty contents. These rows can be identified before sending requests to OpenAI service and getting errors. For now, we are skipping any rows that do not have any user message
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2320 +/- ##
==========================================
+ Coverage 84.44% 84.47% +0.02%
==========================================
Files 328 328
Lines 16771 16776 +5
Branches 1506 1520 +14
==========================================
+ Hits 14163 14171 +8
+ Misses 2608 2605 -3 ☔ View full report in Codecov by Sentry. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
mhamilton723
reviewed
Dec 2, 2024
| @@ -46,8 +46,22 @@ class OpenAIChatCompletion(override val uid: String) extends OpenAIServicesBase( | |||
|
|
|||
| override val subscriptionKeyHeaderName: String = "api-key" | |||
|
|
|||
| override def shouldSkip(row: Row): Boolean = | |||
| super.shouldSkip(row) || Option(row.getAs[Row](getMessagesCol)).isEmpty | |||
| /** | |||
There was a problem hiding this comment.
This seems like something we should likely have in the prompt API as opposed to the core API just because im not sure if its possible to send just system messages and have it reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAIChatCompletionclass methodshouldSkipwas not working as designed as there might OpenAIMessages with empty contents. These rows can be identified before sending requests to OpenAI service and getting errors.What changes are proposed in this pull request?
In this PR, I am making changes to skip rows if there are no user messages in the message column.
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?