Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DRAFT - DO NOT MERGE] df.ai.gen - allow PySpark users to easily leverage OpenAI prompting #2267

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

sss04
Copy link
Contributor

@sss04 sss04 commented Aug 20, 2024

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Briefly describe the changes included in this Pull Request.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@sss04
Copy link
Contributor Author

sss04 commented Aug 20, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sss04 sss04 changed the title [DRAFT - DO NOT MERGE] df.ai.gen - allow PySpark users to easily leverage OpenAI prompting feat: [DRAFT - DO NOT MERGE] df.ai.gen - allow PySpark users to easily leverage OpenAI prompting Aug 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.92%. Comparing base (eb309fe) to head (0f635a7).

Files Patch % Lines
...ure/synapse/ml/services/CognitiveServiceBase.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2267      +/-   ##
==========================================
- Coverage   84.54%   83.92%   -0.62%     
==========================================
  Files         327      327              
  Lines       16775    16775              
  Branches     1499     1523      +24     
==========================================
- Hits        14182    14079     -103     
- Misses       2593     2696     +103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sss04 sss04 marked this pull request as ready for review August 20, 2024 20:10
@sss04 sss04 requested a review from mhamilton723 as a code owner August 20, 2024 20:10
@sss04
Copy link
Contributor Author

sss04 commented Aug 20, 2024

No need to review this right now! I'm just trying to kick off a Synapse build to test this in a Fabric notebook

@sss04
Copy link
Contributor Author

sss04 commented Aug 20, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sss04
Copy link
Contributor Author

sss04 commented Aug 21, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sss04
Copy link
Contributor Author

sss04 commented Aug 21, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants