Skip to content

Transition away from OS-33790456 #5805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

Transition away from OS-33790456 #5805

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2050b9
check for `_STATIC_INLINE_UCRT_FUNCTIONS` to determine if UCRT functi…
davidmrdavid Oct 24, 2025
8005ad6
fix: workaround should be active on older Windows SDKs and only when …
davidmrdavid Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions stl/inc/ctime
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ _EXPORT_STD using _CSTD strftime;
_EXPORT_STD using _CSTD timespec;
#endif // _HAS_CXX17

#ifdef _BUILD_STD_MODULE // TRANSITION, OS-33790456; `template <int = 0>` avoids ambiguity
// `_STATIC_INLINE_UCRT_FUNCTIONS` is exposed by the UCRT starting on Windows SDK `10.0.26100.6901`.
// When set to `1`, several UCRT functions are declared as `static inline` (for historical compatibility),
// preventing them from being naively exported through modules.
// In that case, we use templates to shadow their name, allowing us forcibly to export them.
#if defined(_BUILD_STD_MODULE) && (!defined(_STATIC_INLINE_UCRT_FUNCTIONS) || _STATIC_INLINE_UCRT_FUNCTIONS == 1)
_STL_DISABLE_DEPRECATED_WARNING

_EXPORT_STD template <int = 0>
Expand Down Expand Up @@ -75,7 +79,7 @@ _Check_return_ inline int __CRTDECL timespec_get(_Out_ timespec* const _Ts, _In_
_STL_RESTORE_DEPRECATED_WARNING
#else // ^^^ workaround / no workaround vvv

// _EXPORT_STD has no effect while the workaround is present.
// _EXPORT_STD has no effect when `_BUILD_STD_MODULE` is not defined.
_EXPORT_STD using _CSTD ctime;
_EXPORT_STD using _CSTD difftime;
_EXPORT_STD using _CSTD gmtime;
Expand Down