Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop trying to exclude qcodes from Spyder UMR #6647

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Nov 20, 2024

  • Stop calling add_to_spyder_UMR_excludelist automatically and deprecate this function.
  • Document that users should disable UMR when installing qcodes editable.
  • Breaking change note

Alternative to #6544

@jenshnielsen jenshnielsen requested a review from a team as a code owner November 20, 2024 12:35
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.34%. Comparing base (bd2b3e7) to head (70a19c9).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/qcodes/utils/spyder_utils.py 0.00% 3 Missing ⚠️
src/qcodes/utils/helpers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6647      +/-   ##
==========================================
- Coverage   69.37%   69.34%   -0.03%     
==========================================
  Files         340      340              
  Lines       31293    31296       +3     
==========================================
- Hits        21708    21703       -5     
- Misses       9585     9593       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jenshnielsen jenshnielsen added this to the 0.50.0 milestone Nov 20, 2024
@jenshnielsen jenshnielsen changed the title Stop trying to exclude qcodes from Sypder UMR Stop trying to exclude qcodes from Spyder UMR Nov 20, 2024
@jenshnielsen jenshnielsen added this pull request to the merge queue Nov 21, 2024
Merged via the queue into microsoft:main with commit 8e9bf7c Nov 21, 2024
15 of 17 checks passed
@jenshnielsen jenshnielsen deleted the remove_spyder_exclude branch November 22, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants