Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make command caller get/set_raw a method #5724

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Make command caller get/set_raw a method #5724

wants to merge 15 commits into from

Commits on Oct 24, 2024

  1. convert Command call into a method to match get/set_raw on other para… 

    …meters
    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    ef3c78e View commit details
    Browse the repository at this point in the history

  2. better error message in command

    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    681cbfa View commit details
    Browse the repository at this point in the history

  3. debug reraise error

    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7562a2f View commit details
    Browse the repository at this point in the history

  4. Remove unneeded ignores

    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    2fbf9a6 View commit details
    Browse the repository at this point in the history

  5. Avoid using Command for get

    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    4e69416 View commit details
    Browse the repository at this point in the history

  6. format error better

    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    4dc0211 View commit details
    Browse the repository at this point in the history

  7. Remove no longer uses internal func

    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a699e26 View commit details
    Browse the repository at this point in the history

  8. Clarify a few things for get

    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    fdd70ab View commit details
    Browse the repository at this point in the history

  9. Replace set_cmd with method

    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    4c56c7e View commit details
    Browse the repository at this point in the history

  10. Fix get formatter

    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    fc1305c View commit details
    Browse the repository at this point in the history

  11. Fix set formatter

    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    beab2c2 View commit details
    Browse the repository at this point in the history

  12. Add missing type annotations

    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5ee06bc View commit details
    Browse the repository at this point in the history

  13. Better todo

    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1485b53 View commit details
    Browse the repository at this point in the history

  14. reformat

    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5a8f53c View commit details
    Browse the repository at this point in the history

  15. Add non working test

    @jenshnielsen
    jenshnielsen committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1748622 View commit details
    Browse the repository at this point in the history