-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run pyright with standard checks #5721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:16
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:16
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:16
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:16
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:16
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:16
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:33
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:33
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:33
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:33
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:33
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:33
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:34
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:34
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:34
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:34
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:34
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 3, 2024 10:34
— with
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5721 +/- ##
==========================================
- Coverage 67.55% 67.54% -0.02%
==========================================
Files 348 348
Lines 30246 30251 +5
==========================================
- Hits 20434 20433 -1
- Misses 9812 9818 +6 ☔ View full report in Codecov by Sentry. |
jenshnielsen
temporarily deployed
to
testing-environment
February 4, 2024 06:47
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 4, 2024 06:47
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 4, 2024 06:47
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 4, 2024 06:47
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 4, 2024 06:47
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 4, 2024 06:47
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 4, 2024 07:07
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 4, 2024 07:07
— with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 4, 2024 07:07
— with
GitHub Actions
Inactive
jenshnielsen
force-pushed
the
pyright_standard
branch
2 times, most recently
from
February 28, 2024 09:19
d8bf81f
to
895f1b7
Compare
This is in principle a breaking change but seems very unlikely that these inputs would be passed by kwarg
This is a breaking change but seems very unlikly to be called by directly
These are breaking changes but since the arguments had no effect unlikely to be an issue
jenshnielsen
force-pushed
the
pyright_standard
branch
from
March 4, 2024 08:54
895f1b7
to
f9fa4ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically means checking that overrides are compatible with the base class
Breaking changes
InstrumentModule/Channel obj -> value in Sequence/MutableSequence methods. IMHO unlikely to be called by arg since these are simple single argument methods.Left this one out for now and ignored the warnings